Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Reverts skipped tests caused by null API name #71632

Merged
merged 6 commits into from
Jul 15, 2020

Conversation

tylersmalley
Copy link
Contributor

elastic/elasticsearch#59485 has fixed this in ES upstream, however, it's not something which will be supported for much longer (elastic/elasticsearch#59485). A fix to ensure API keys have names is here: #71623

Closes #71582
Closes #71558
Closes #71555
Closes #71559

@tylersmalley
Copy link
Contributor Author

Blocked on promotion of last nights builds.

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review July 15, 2020 15:48
@tylersmalley tylersmalley requested review from a team as code owners July 15, 2020 15:48
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v7.9.0 v8.0.0 labels Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member

mistic commented Jul 15, 2020

@elasticmachine merge upstream

1 similar comment
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting code LGTM

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@tylersmalley
Copy link
Contributor Author

Re-running tests to ensure merging #71727 did not create any issues.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

miscellaneous assets size

id value diff baseline
upgradeAssistant 22.6KB +4.0B 22.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit d27ac2d into elastic:master Jul 15, 2020
@tylersmalley tylersmalley deleted the revert-skipped-tests branch July 15, 2020 18:53
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jul 15, 2020
* Revert "[test] Skips test preventing promotion of ES snapshot elastic#71582"

This reverts commit 683fb42.

* Revert "[test] Skips test preventing promotion of ES snapshot elastic#71555"

This reverts commit 8555ecb.

* Revert "[test] Skips Alerting test preventing ES snapshot promotion"

This reverts commit b217cb3.

* Revert "[test] Skips test preventing promotion of ES snapshot"

This reverts commit 0194f8c.

* Revert "[skip test] Skips Alerting API test due to failing ES promotion"

This reverts commit 439f2dd.
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jul 15, 2020
* Revert "[test] Skips test preventing promotion of ES snapshot elastic#71582"

This reverts commit 683fb42.

* Revert "[test] Skips test preventing promotion of ES snapshot elastic#71555"

This reverts commit 8555ecb.

* Revert "[test] Skips Alerting test preventing ES snapshot promotion"

This reverts commit b217cb3.

* Revert "[test] Skips test preventing promotion of ES snapshot"

This reverts commit 0194f8c.

* Revert "[skip test] Skips Alerting API test due to failing ES promotion"

This reverts commit 439f2dd.
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
* Revert "[test] Skips test preventing promotion of ES snapshot #71582"

This reverts commit 683fb42.

* Revert "[test] Skips test preventing promotion of ES snapshot #71555"

This reverts commit 8555ecb.

* Revert "[test] Skips Alerting test preventing ES snapshot promotion"

This reverts commit b217cb3.

* Revert "[test] Skips test preventing promotion of ES snapshot"

This reverts commit 0194f8c.

* Revert "[skip test] Skips Alerting API test due to failing ES promotion"

This reverts commit 439f2dd.
tylersmalley pushed a commit that referenced this pull request Jul 15, 2020
* Revert "[test] Skips test preventing promotion of ES snapshot #71582"

This reverts commit 683fb42.

* Revert "[test] Skips test preventing promotion of ES snapshot #71555"

This reverts commit 8555ecb.

* Revert "[test] Skips Alerting test preventing ES snapshot promotion"

This reverts commit b217cb3.

* Revert "[test] Skips test preventing promotion of ES snapshot"

This reverts commit 0194f8c.

* Revert "[skip test] Skips Alerting API test due to failing ES promotion"

This reverts commit 439f2dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment