Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.9] [Resolver] aria-level and aria-flowto support enhancements (#71887) #71953

Merged
merged 1 commit into from
Jul 16, 2020
Merged

[7.9] [Resolver] aria-level and aria-flowto support enhancements (#71887) #71953

merged 1 commit into from
Jul 16, 2020

Conversation

oatkiller
Copy link
Contributor

Backports the following commits to 7.9:

[Resolver] aria-level and aria-flowto support enhancements (elastic#7…
916545b 
…1887)

* `IndexedProcessTree` now owns the concern of defining the order of siblings
* `IsometricTaxiLayout` now owns the concept of `ariaLevels`
* added `datetime` method to `process_event` model which returns a time in ms since unix epoch for the event
* renamed some resolver selectors
* added resolver selector: `ariaLevel`
* added 'data' selector: `followingSibling` (used for aria-flowto)
* added resolver selector `ariaFlowtoNodeID` which takes a nodeID, and returns its following sibling's node id (if that sibling is visible.) By only returning visible siblings, we ensure that `aria-flowto` will point to an html ID that is in the dom.
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack EPM API Integration Tests.x-pack/test/ingest_manager_api_integration/apis/epm/install·ts.Ingest Manager Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/71939

[00:00:00]       │
[00:00:00]         └-: Ingest Manager Endpoints
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: installs packages that include settings and mappings overrides
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should install the overrides package correctly
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40120, url.original: /search?package=overrides&internal=true&experimental=true&kibana.version=7.9.0
[00:00:00]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40124, url.original: /package/overrides/0.1.0
[00:00:00]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40128, url.original: /package/overrides/0.1.0/
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40134, url.original: /search?kibana.version=7.9.0
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40138, url.original: /package/overrides/0.1.0
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40142, url.original: /package/overrides/0.1.0/
[00:00:01]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xl-1594845428754442209] [.kibana_1/tywv0YIFSuCWlPOs00FG2Q] update_mapping [_doc]
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40146, url.original: /search?kibana.version=7.9.0
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40150, url.original: /package/overrides/0.1.0
[00:00:01]               │ info [docker:registry] 2020/07/15 21:57:42 source.ip: 172.17.0.1:40154, url.original: /package/overrides/0.1.0/
[00:00:02]               └- ✖ fail: Ingest Manager Endpoints installs packages that include settings and mappings overrides should install the overrides package correctly
[00:00:02]               │      Error: expected 200 "OK", got 409 "Conflict"
[00:00:02]               │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:00:02]               │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:00:02]               │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:00:02]               │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:00:02]               │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:00:02]               │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
[00:00:02]               │       at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
[00:00:02]               │       at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:00:02]               │       at endReadableNT (_stream_readable.js:1145:12)
[00:00:02]               │       at process._tickCallback (internal/process/next_tick.js:63:19)
[00:00:02]               │ 
[00:00:02]               │

Stack Trace

Error: expected 200 "OK", got 409 "Conflict"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
    at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
    at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller merged commit 8cb4e35 into elastic:7.9 Jul 16, 2020
@oatkiller oatkiller deleted the backport/7.9/pr-71887 branch March 31, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oatkiller @kibanamachine