Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Detections] Fixes faulty circuit breaker #71999

Merged
merged 7 commits into from
Jul 20, 2020
Merged

[SIEM] [Detections] Fixes faulty circuit breaker #71999

merged 7 commits into from
Jul 20, 2020

Commits on Jul 20, 2020

  1. removes useSortIds which was leftover from a previous attempt at impl… 

    …ementing gap detection mitigation code. This only showed up because I modified the count variable used to determine when we hit maxSignals from utilizing the searchResult hits length to using the count of bulk created items (signals indexed) in this commit 56de45d
    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    9e5de4f View commit details
    Browse the repository at this point in the history

  2. removes logs and fixes if statement ordering

    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    bce2d81 View commit details
    Browse the repository at this point in the history

  3. adds tests, increases code coverage for search after and bulk create … 

    …function, updates log statements
    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    bd55db6 View commit details
    Browse the repository at this point in the history

  4. update tests after rebase onto master

    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    24064de View commit details
    Browse the repository at this point in the history

  5. clean up if statements

    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    cc91be2 View commit details
    Browse the repository at this point in the history

  6. fix test data

    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    9d0cc73 View commit details
    Browse the repository at this point in the history

  7. merge conflicts are hard

    @dhurley14
    dhurley14 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2f0f43d View commit details
    Browse the repository at this point in the history