Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - remove by_field_count check for categorization jobs #72033

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jul 16, 2020

Summary

This PR removes the validation of total_by_field_count for categorization jobs because the number of detected categories is not necessarily stable across analytics changes.

Closes #71971

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 16, 2020
@pheyos pheyos self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jul 16, 2020

Checking test stability in a flaky test runner job...
=> No failure in 50 runs ✔️

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 35e1dd6 into elastic:master Jul 16, 2020
@pheyos pheyos deleted the fix_categorization_tests branch July 16, 2020 13:22
pheyos added a commit to pheyos/kibana that referenced this pull request Jul 16, 2020
…n jobs (elastic#72033)

This PR removes the validation of `total_by_field_count` for categorization jobs because the number of detected categories is not necessarily stable across analytics changes.
pheyos added a commit to pheyos/kibana that referenced this pull request Jul 16, 2020
…n jobs (elastic#72033)

This PR removes the validation of `total_by_field_count` for categorization jobs because the number of detected categories is not necessarily stable across analytics changes.
pheyos added a commit that referenced this pull request Jul 16, 2020
…n jobs (#72033) (#72051)

This PR removes the validation of `total_by_field_count` for categorization jobs because the number of detected categories is not necessarily stable across analytics changes.
pheyos added a commit that referenced this pull request Jul 16, 2020
…n jobs (#72033) (#72052)

This PR removes the validation of `total_by_field_count` for categorization jobs because the number of detected categories is not necessarily stable across analytics changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants