Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Fix issues displaying alerts #72891

Merged
merged 5 commits into from
Jul 22, 2020

Conversation

chrisronline
Copy link
Contributor

Resolves #72862

In our logic to detect firing alert states, we mistakenly did not account for the firing flag directly and as a result, instances which were firing in the past still showed up in the UI. In addition to this, when a single alert had multiple alert instances, the UI was just using the first one for all messaging, instead of showing for each one.

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 22, 2020
@chrisronline chrisronline requested a review from a team July 22, 2020 15:52
@chrisronline chrisronline self-assigned this Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
monitoring 1.1MB +1.1KB 1.1MB

page load bundle size

id value diff baseline
monitoring 294.3KB +510.0B 293.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! I was able to test/confirm it using observability clusters Thanks for the instructions 🙇

@chrisronline chrisronline merged commit bacf9f2 into elastic:master Jul 22, 2020
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 22, 2020
* Fix issues displaying alerts

* Fix type issues

* More support for multiple alerts

Co-authored-by: Elastic Machine <[email protected]>
chrisronline added a commit that referenced this pull request Jul 23, 2020
* Fix issues displaying alerts

* Fix type issues

* More support for multiple alerts

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
chrisronline added a commit that referenced this pull request Jul 23, 2020
* Fix issues displaying alerts

* Fix type issues

* More support for multiple alerts

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 23, 2020
* master: (35 commits)
  Migrated karma tests to jest (elastic#72649)
  Migrate status page app to core (elastic#72017)
  Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834)
  Fix Firefox TSVB flaky test with switch index patterns (elastic#72882)
  [ML] Fixing link to index management from file data visualizer (elastic#72863)
  test: 💍 add test for sub-expression variables (elastic#71644)
  fix bug (elastic#72809)
  [keystore] use get_keystore in server cli (elastic#72954)
  Show step number instead of incomplete step. (elastic#72866)
  Fix bug where user can't add an exception when "close alert" is checked (elastic#72919)
  [Monitoring] Fix issues displaying alerts (elastic#72891)
  [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338)
  [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490)
  disable renovate masterIssue
  [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710)
  [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926)
  [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763)
  [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759)
  fix unexpected arguments to unload command
  Limits the upload size of lists to 9 meg size (elastic#72898)
  ...
@chrisronline
Copy link
Contributor Author

Backport:

7.9: 312f073
7.x: 5ff15b2

@chrisronline chrisronline deleted the monitoring/multiple_alerts branch July 23, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Alerts that are not firing still show up in the UI
4 participants