expose es config on es setup contract #73055
Conversation
| /** | ||
| * Provide direct access to the current elasticsearch configuration. | ||
| * | ||
| * @deprecated this will be removed in a later version. | ||
| */ | ||
| readonly config$: Observable<ElasticsearchConfig>; |
There was a problem hiding this comment.
-
I could have kept
legacy.config$and expose it on the public contract instead, but now that this is going to be consumed by KP plugins, I thought it was better on top level. Also, that would allow to totally get rid ofesSetup.legacywhen we remove the legacy client -
flagged it as deprecated. Not sure if it's the right move.
There was a problem hiding this comment.
I'd prefer to keep it under legacy namespace to make it even more explicit that we are going to remove it. @joshdover any thoughts?
There was a problem hiding this comment.
Deprecation tags are easy to miss (they're really only present in intellisense right now since we don't have any linter warnings for using deprecated APIs). Given that, I also prefer keeping it under the legacy namespace to make it clear that this will be removed in the future.
There was a problem hiding this comment.
Related, this new feature in TS v4 / VSCode will make deprecated APIs more apparent: https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-rc/#deprecated-support
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
* expose es config on es setup contract * move config$ back to legacy
Summary
Required for #68497
Expose
legacy.config$on ES service setup contractChecklist