Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove karma #73126

Merged
merged 6 commits into from
Jul 27, 2020
Merged

Remove karma #73126

merged 6 commits into from
Jul 27, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 23, 2020

In an effort to move forward with our transition to Jest and the Kibana Platform it's time to move off of Karma.

There are still a number of tests in KP plugins which haven't been running for a while and need to be migrated to Jest in the near term: #71002

Legacy platform plugins that exist are working on migrating off the Karma right now and have agreed that it's not a problem if we remove Karma now before they've finished the migration.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 23, 2020
@spalger spalger marked this pull request as ready for review July 23, 2020 23:46
@spalger spalger requested review from a team as code owners July 23, 2020 23:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for Canvas!

Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for platform changes

@spalger
Copy link
Contributor Author

spalger commented Jul 27, 2020

Oops, accidentally pushed a commit from #73154 into this PR

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit dd4796c into elastic:master Jul 27, 2020
@spalger spalger deleted the remove/karma branch July 27, 2020 18:08
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 27, 2020
Co-authored-by: spalger <[email protected]>
# Conflicts:
#	docs/developer/contributing/development-unit-tests.asciidoc
#	tasks/config/run.js
#	test/scripts/jenkins_xpack.sh
#	x-pack/tasks/test.ts
#	yarn.lock
spalger added a commit that referenced this pull request Jul 28, 2020
Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@jinmu03 jinmu03 mentioned this pull request Aug 5, 2020
54 tasks
@jbudz jbudz mentioned this pull request Aug 17, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants