Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Detections] Adds ip_range and text types to value list upload form (#73109) #73301

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Jul 27, 2020

Backports the following commits to 7.x:

… list upload form (elastic#73109)

* Adds two more types to the value lists form

* Adds `ip_range` and `text` types
* Replaces radio group with select

* Add custom command for attaching a file to an input

This will be used to excercise value list uploads.

* Add some missing test subjects for our value lists modal

* Add cypress test for value lists modal

This exercises the happy path: opening the modal, uploading a list, and
asserting that it subsequently appears in the table.

Co-authored-by: Elastic Machine <[email protected]>
@rylnd rylnd added the backport label Jul 27, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +311.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 965939c into elastic:7.x Jul 27, 2020
@rylnd rylnd deleted the backport/7.x/pr-73109 branch July 27, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants