Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][Timelines] Updates timeline template callout text #73334

Merged

Conversation

MadameSheema
Copy link
Member

Summary

Following @MikePaquette observations, we are updating the callout text from the timeline template.

BEFORE:

88537493-adddc080-cfdb-11ea-8ef1-66ffad8559e5

AFTER:

Screenshot 2020-07-27 at 20 24 06

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 27, 2020
@MadameSheema MadameSheema requested review from a team as code owners July 27, 2020 18:30
@MadameSheema MadameSheema self-assigned this Jul 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -27.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MadameSheema

@MadameSheema MadameSheema merged commit 1c791f3 into elastic:master Jul 28, 2020
@MadameSheema MadameSheema deleted the updates-timeline-template-text branch July 28, 2020 08:48
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 28, 2020
* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 28, 2020
* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
* master: (44 commits)
  [Search] add server logs (elastic#72454)
  [SIEM][Timelines] Updates timeline template callout text (elastic#73334)
  Fix App status  flaky test (elastic#72853)
  [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243)
  Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468)
  fix dashboard index pattern race condition (elastic#72899)
  [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255)
  [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238)
  updates cypress to v4.11.0 (elastic#73327)
  [Metrics UI] Saved views bugs (elastic#72518)
  [Ingest Manager] Convert select agent config step to use combo box (elastic#73172)
  Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128)
  [Security Solution][ML] Updates siem group name to security (elastic#73218)
  [Security Solution] Show proper icon for termination status of all processes (elastic#73235)
  [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313)
  [Security solution] Threat hunting test coverage improvements (elastic#73276)
  [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129)
  [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324)
  [dev/build/docker_generator] convert to typescript (elastic#73339)
  [APM] Fix focus map link on service map (elastic#73338)
  ...
MadameSheema added a commit that referenced this pull request Jul 28, 2020
…3416)

* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
MadameSheema added a commit that referenced this pull request Jul 28, 2020
…3417)

* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
tylersmalley pushed a commit that referenced this pull request Jul 28, 2020
tylersmalley pushed a commit that referenced this pull request Jul 28, 2020
* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants