Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver] Remove useless check that breaks when tree has no nodes #73583

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

oatkiller
Copy link
Contributor

If process event collection is disabled an alert event can still be triggered that has process.entity_id. Resolver will try to graph it but it will have no process events. The error would be triggered. Without the error, the user gets an empty resolver, but at least it doesn't crash.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@oatkiller oatkiller requested review from a team as code owners July 28, 2020 23:55
@oatkiller oatkiller changed the title Remove error check. [Resolver] Remove useless check that breaks when tree has no nodes Jul 28, 2020
@oatkiller oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 28, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: Timed out retrying: Too many elements found. Found '9', expected '8'.
    at Context.eval (http://localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts:684:49)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -33.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants