Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding initial file analysis overrides #74376

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 5, 2020

Adds the ability to edit the override settings if the initial analysis has failed.
This allows the user to add some domain knowledge to help the find_file_structure endpoint work out the rest of the file structure.

image

image

to test, this data can be added to a file and uploaded:

2344:20200424:175400.779 response code: 200
2344:20200424:175500.519 response code: 200
2344:20200424:175710.752 response code: 200
2344:20200424:175710.777 response code: 503
2344:20200424:175800.001 response code: 200
2344:20200424:175800.006 response code: 404
2344:20200424:175800.315 response code: 200
2344:20200424:175800.535 response code: 200
2344:20200424:175800.769 response code: 201
2344:20200424:175900.411 response code: 200
2344:20200424:175900.648 response code: 200
2344:20200424:180000.444 response code: 200
2344:20200424:180000.777 response code: 200
2344:20200424:180100.537 response code: 200
2344:20200424:180100.890 response code: 504

Fixes #38868

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

cc @droberts195

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also did a local test with the provided sample.

{!loading && !loaded && <AboutPanel onFilePickerChange={this.onFilePickerChange} />}
<>
{!loading && !loaded && (
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this fragment wrapper can be removed since it's only one element on the inside, maybe a leftover from refactoring?

<FileCouldNotBeRead
error={serverError}
loaded={loaded}
showEditFlyout={() => this.showEditFlyout()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this.showEditFlyout need to be wrapped in an arrow function here?

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question but otherwise LGTM ⚡

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 7.9MB +2.8KB 7.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 6bea373 into elastic:master Aug 11, 2020
@jgowdyelastic jgowdyelastic deleted the adding-initial-file-analysis-overrides branch August 11, 2020 07:47
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 11, 2020
* [ML] Adding initial file analysis overrides

* using common default sample lines

* correcting bottom padding

* adding missed padding

* code clean up

* fixing translations

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
* master: (339 commits)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482)
  [ML] Fixing schema for custom rule conditions (elastic#74676)
  [ML] Refactor in preparation for new es client (elastic#74552)
  [ML] Adding initial file analysis overrides (elastic#74376)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  [Ingest Manager] Allow prerelease in package version (elastic#74452)
  [App Arch]: remove legacy karma tests (elastic#74599)
  ...
@fbaligand
Copy link
Contributor

Great new feature!

jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2020
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (26 commits)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482)
  [ML] Fixing schema for custom rule conditions (elastic#74676)
  [ML] Refactor in preparation for new es client (elastic#74552)
  [ML] Adding initial file analysis overrides (elastic#74376)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  ...
jgowdyelastic added a commit that referenced this pull request Aug 11, 2020
* [ML] Adding initial file analysis overrides

* using common default sample lines

* correcting bottom padding

* adding missed padding

* code clean up

* fixing translations

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] File Data Viz should allow retry with overrides when initial analysis fails
6 participants