Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] remove unused less fork #74969

Closed
wants to merge 1 commit into from
Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 13, 2020

By removing the legacy optimizer in #73154 we are no longer using the less package, and don't need to keep our fork of the package either. I've deprecated the versions on npm and have cleaned up the repo too.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Build metrics

‼️ metrics were not reported for [#74969@a4ab97c]

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Aug 13, 2020

Oh, turns out we support specifying arbitrary less in TSVB!

@spalger spalger closed this Aug 13, 2020
@spalger spalger deleted the remove/less branch August 13, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants