Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returned payload by "search" usage collector #75340

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 18, 2020

Summary

Related to #70677. This PR fixes the output of the search performed in the fetcher to match the actual expected structure (as defined in the Usage interface).

For maintainers

@afharo afharo added Feature:Search Querying infrastructure in Kibana Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.1 labels Aug 18, 2020
@afharo afharo requested review from lukasolson and a team August 18, 2020 17:34
@afharo afharo marked this pull request as ready for review August 18, 2020 18:05
@afharo afharo requested a review from a team as a code owner August 18, 2020 18:05
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo
Copy link
Member Author

afharo commented Aug 21, 2020

@elasticmachine merge upstream

@afharo afharo added the review label Aug 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit a9b62a8 into elastic:master Aug 21, 2020
@afharo afharo deleted the telemetry/fix-data-search-usage-collector branch August 21, 2020 17:19
afharo added a commit to afharo/kibana that referenced this pull request Aug 21, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 21, 2020
* master: (71 commits)
  [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772)
  Skip failing lens test
  Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074)
  Fix returned payload by "search" usage collector (elastic#75340)
  [Security Solution] Fix missing key error (elastic#75576)
  Upgrade EUI to v27.4.1 (elastic#75240)
  Update datasets UI copy to data streams (elastic#75618)
  [Lens] Register saved object references (elastic#74523)
  [DOCS] Update links to Beats documentation (elastic#70380)
  [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616)
  [Usage Collection Schemas] Remove Legacy entries (elastic#75652)
  [Dashboard First] Lens Originating App Breadcrumb (elastic#75470)
  Improve login UI error message. (elastic#75642)
  [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579)
  [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163)
  Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536)
  [Console] Get ES Config from core (elastic#75406)
  [Uptime] Add delay in telemetry test (elastic#75162)
  [Lens] Use index pattern service instead saved object client (elastic#74654)
  Embeddable input (elastic#73033)
  ...
afharo added a commit that referenced this pull request Aug 21, 2020
afharo added a commit that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes review v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants