Convert to using new status, and remove legacy plugin #75806
Conversation
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
| this.kibanaStatusGetter = getter; | ||
| this.kibanaStatus = null; | ||
| this.kibanaStatusGetter$ = statusGetter$.subscribe((nextStatus) => { | ||
| this.kibanaStatus = nextStatus.level.toString(); |
There was a problem hiding this comment.
nit: instead of converting to a string, you could import ServiceStatusLevels from core/server and do comparisons below:
if (this.kibanaStatus === ServiceStatusLevels.available) { }
// etc
This will make refactoring easier if we ever decide to change the names of these.
There was a problem hiding this comment.
Yes, great point. I had assumed incorrectly I couldn't import it because it was a typescript interface but it's just a constant.
chrisronline
force-pushed
the
monitoring/remove_legacy
branch
from
f5880a5
to
d5c2677
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
|
|
||
| setKibanaStatusGetter(getter) { | ||
| this.kibanaStatusGetter = getter; | ||
| this.kibanaStatus = null; |
There was a problem hiding this comment.
nit: I don't think you need to do this, since the constructor is only executed once (and the default value is already undefined)
* Convert to using new status, and remove legacy plugin * PR feedback * Fix test Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # .github/CODEOWNERS
|
Backport: 7.x: ed93d27 |
Refers to #75503
Now that the status API is now available, we can deprecate the legacy monitoring plugin entirely and leverage the new status API to get status information.