Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app switcher] nav link enhancements #7601

Merged
merged 21 commits into from
Jul 5, 2016
Merged

[app switcher] nav link enhancements #7601

merged 21 commits into from
Jul 5, 2016

Commits on Jul 1, 2016

  1. Method to get nav link by its title + control nav link display state

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    8df249b View commit details
    Browse the repository at this point in the history

  2. Add tooltip to nav link

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    2712203 View commit details
    Browse the repository at this point in the history

  3. Refactoring: extracting functions

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    96588bd View commit details
    Browse the repository at this point in the history

  4. Giving nav links an ID 

    For plugins, by default the plugin ID is used as the nav link ID. This can be overridden by explicitly specifying an ID on the nav link (useful for plugins that register multiple nav links).
    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    b25456a View commit details
    Browse the repository at this point in the history

  5. Fixing test so it passes

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    0b1acad View commit details
    Browse the repository at this point in the history

  6. Throw error if nav link with given ID is not found

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    9161c0c View commit details
    Browse the repository at this point in the history

  7. Adding unit test for toJSON()

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    bb45a39 View commit details
    Browse the repository at this point in the history

  8. Fixing minor typo

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    921533a View commit details
    Browse the repository at this point in the history

  9. Adding unit test for constructor

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    7e931bd View commit details
    Browse the repository at this point in the history

  10. Outdenting closing bracket per styleguide

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    a8995e3 View commit details
    Browse the repository at this point in the history

  11. Use ES6 find instead of _.find

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    a376c03 View commit details
    Browse the repository at this point in the history

  12. Using ES6 template literal instead of old school string concatenation

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    f4390ba View commit details
    Browse the repository at this point in the history

  13. Using native Array.prototype.filter() instead of _.filter()

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    30032c5 View commit details
    Browse the repository at this point in the history

  14. Using class instead of element selector

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    8dac9c3 View commit details
    Browse the repository at this point in the history

  15. Adding unit tests for default paths involving various properties

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    2601fcf View commit details
    Browse the repository at this point in the history

  16. Adding hidden, disabled and tooltip properties to UiNavLink class

    @ycombinator
    ycombinator committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    42cc301 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2016

  1. Replace 2 assertions with 1

    @ycombinator
    ycombinator committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    de1ea90 View commit details
    Browse the repository at this point in the history

  2. Remove unused var

    @ycombinator
    ycombinator committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    81072ad View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2016

  1. Merge branch 'master' into app-switcher/nav-link-enhancements

    @ycombinator
    ycombinator committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    03eebad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into app-switcher/nav-link-enhancements

    @ycombinator
    ycombinator committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    3a8948f View commit details
    Browse the repository at this point in the history

  3. Return early from function

    @ycombinator
    ycombinator committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    c8b4d2d View commit details
    Browse the repository at this point in the history