Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home: replace /elasticsearch/_msearch calls with custom endpoint #76259

Merged
merged 1 commit into from
Aug 31, 2020
Merged

home: replace /elasticsearch/_msearch calls with custom endpoint #76259

merged 1 commit into from
Aug 31, 2020

Conversation

pgayvallet
Copy link
Contributor

Summary

Fix #73992

Replace call to /elasticsearch/_msearch in src/plugins/home/public/application/components/tutorial/tutorial.js with a custom endpoint.

Checklist

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0 Feature:Legacy Removal Issues related to removing legacy Kibana labels Aug 31, 2020
@pgayvallet pgayvallet changed the title replace /elasticsearch/_msearch usages with custom endpoint home: replace /elasticsearch/_msearch calls with custom endpoint Aug 31, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
home 568.8KB -320.0B 569.1KB

oss distributable file count

id value diff baseline
total 26253 +2 26251

distributable file count

id value diff baseline
total 44375 +2 44373

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review August 31, 2020 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@pgayvallet pgayvallet requested a review from a team August 31, 2020 10:16
ryankeairns
ryankeairns approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully configured the following items, achieving a 'green' status for each tutorial:

  • Kibana metrics (metricbeat)
  • Auditbeat
  • System logs (filebeat)
  • APM server

Thanks for making these changes!

@pgayvallet pgayvallet merged commit 325b82b into elastic:master Aug 31, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Aug 31, 2020
@pgayvallet
replace /elasticsearch/_msearch usages with custom endpoint (elastic#…
25a78ad 
…76259)
@pgayvallet pgayvallet mentioned this pull request Aug 31, 2020
Merged
pgayvallet added a commit that referenced this pull request Sep 1, 2020
@pgayvallet
replace /elasticsearch/_msearch usages with custom endpoint (#76259) (#…
db735b3 
…76326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usage of /elasticsearch/_msearch endpoint in tutorials
4 participants
@pgayvallet @kibanamachine @elasticmachine @ryankeairns