Show notifier on page load, if notifier params are in query string

[ycombinator]

An application may want to redirect to Kibana and show a toast notification post-redirect. This PR enables this functionality.

Specifically, if the Kibana app finds a query string parameter named notif_msg, it will create a Notifier with the value of that parameter as its message. Optionally, two additional query string parameters may be passed:

• notif_lvl for notification level (error, warning, etc.). Default = info.
• notif_loc for notification location. Default = no location is set.

[ycombinator]

Some questions I have about the code in this PR:

1. Is src/core_plugins/kibana/public/kibana.js the right place to define the showNotifier function? Or should it be its own module elsewhere? If so, where?
2. Should the showNotifier function be invoked via modules.get('kibana').run()? Or is there a better lifecycle hook to use?
3. Is using the three notif_* query string parameters really the best way to pass the information into the app? Or should they be one parameter that's perhaps rison-encoded? Or something else?

[w33ble]

Can this use markdown in notif_msg for rich notifications? I don't actually know if the notifier works that way, or if you have to specify that you're using markdown or otherwise want to render rich content.

[ycombinator]

Can this use markdown in notif_msg for rich notifications?

From my testing, if notif_msg contains a markdown link and notif_lvl is banner, the link is rendered in the notification.

[epixa]

What do you think about removing the value from the query string (using $location.replace() as to not leave an item in history) so that people don't accidentally pass around links that add a notification? Would that work for the licensing stuff?

[ycombinator]

What do you think about removing the value from the query string ...?

I imagine you mean right after the notification has been triggered. Yeah, I think that is a good idea. It should work for licensing as well.

[ycombinator]

jenkins, test it

[spalger]

I like this approach much better, but I think Notifier.run should probably be Notifier.pullMessagesFromUrl or something

[spalger]

LGTM