Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form lib] Fix regression on field not being validated after reset to its default value. #76379

Merged
merged 2 commits into from
Sep 3, 2020
Merged

[Form lib] Fix regression on field not being validated after reset to its default value. #76379

merged 2 commits into from
Sep 3, 2020

Commits on Sep 1, 2020

  1. Remove the condition that prevent the field validation to run when va… 

    …lue === defaultValue

I introduced a regression when I added an "if" condition to prevent validation when the field value === the initial value. This if was added to prevent validating after resetting the field value. This created a regression as now the validation was never run on empty fields.
    @sebelga
    sebelga committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    efa9700 View commit details
    Browse the repository at this point in the history

  2. Remove comments

    @sebelga
    sebelga committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    7a2c045 View commit details
    Browse the repository at this point in the history