[Discover] Fix time zone switch functional test in cloud env #76396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
commented
Sep 2, 2020
| async pressTabKey() { | ||
| await browser.pressKeys(browser.keys.TAB); | ||
| } | ||
|
|
||
| // Pause the browser at a certain place for debugging | ||
| // Not meant for usage in CI, only for dev-usage | ||
| async pause() { |
There was a problem hiding this comment.
this is now completely off topic, but I was just excited to find a pause function for the functional tests 🥳
kertal
commented
Sep 2, 2020
| @@ -54,6 +54,11 @@ export function QueryBarProvider({ getService, getPageObjects }: FtrProviderCont | |||
| }); | |||
| } | |||
|
|
|||
| public async clearQuery(): Promise<void> { | |||
| await this.setQuery(''); | |||
| await PageObjects.common.pressTabKey(); | |||
There was a problem hiding this comment.
moving focus by tab closes the query bar suggestions, also the time picker is then displayed again, which simplifies the code of the failing Discover test
kertal
changed the title
|
@elasticmachine merge upstream |
…al-test-timezone-switch
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Sep 4, 2020
…#76396) # Conflicts: # test/functional/page_objects/common_page.ts
kertal
added a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The overlapping of the query bar with the index pattern selector caused a test fail in cloud. Setting the query bar to '' triggered displaying suggestions, overlapping the index pattern selector. So this PR adds a new function to clear the query, which is followed by a
TABto move focus to the next tabbable element.Here's the test run to prove that it no longer fails:
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/105/
Fixes #76166
Checklist