Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement for manage_index_templates privilege for Index Management #77377

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Remove requirement for manage_index_templates privilege for Index Management #77377

merged 3 commits into from
Sep 22, 2020

Conversation

cjcenizal
Copy link
Contributor

#67791 introduced the requirement that users have the monitor and manage_index_templates privileges in order to use Index Management. Requiring manage_index_templates is too restrictive because users can still use Index Management to view and manage their indices. This PR removes this requirement, though there are still rough edges remaining which we'll have to address in subsequent PRs, tracked by #77376.

@cjcenizal cjcenizal added chore Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 14, 2020
@cjcenizal cjcenizal requested a review from a team as a code owner September 14, 2020 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth
alisonelizabeth approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Did not test locally.

@legrego
Copy link
Member

legrego commented Sep 22, 2020

Sorry about that! If I had paid closer attention to the existing docs, then I could have caught this.

This PR removes this requirement, though there are still rough edges remaining which we'll have to address in subsequent PRs, tracked by #77376.

The privilege model introduced in #67791 will allow you to take advantage of UI Capabilities for this, if that's something you're interested in doing (instead of doing the privilege checks yourself). Either way is fine with me, just letting you know there are options. Happy to help when the time comes!

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal
Copy link
Contributor Author

Thanks @legrego! I'm going to merge this for now and we'll follow up with exploring UI Capabilities later.

@cjcenizal cjcenizal merged commit 07b7b06 into elastic:master Sep 22, 2020
@cjcenizal cjcenizal deleted the bug/index-management-privileges branch September 22, 2020 21:47
@cjcenizal cjcenizal mentioned this pull request Sep 22, 2020
Merged
cjcenizal added a commit that referenced this pull request Sep 22, 2020
@cjcenizal
Remove requirement for manage_index_templates privilege for Index Man…
cfb4899 
…agement (#77377) (#78224)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
@gmmorris
Merge branch 'master' into actions/pagerduty-dedup
097b99d 
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
chore Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjcenizal @elasticmachine @legrego @kibanamachine @alisonelizabeth