Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APM e2e tests #77415

Closed
wants to merge 2 commits into from
Closed

Fix APM e2e tests #77415

wants to merge 2 commits into from

Conversation

smith
Copy link
Contributor

@smith smith commented Sep 14, 2020

Looks like #67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.

@smith
Fix APM e2e tests
543e00f 
Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 14, 2020
@smith smith requested a review from a team as a code owner September 14, 2020 21:36
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte
ogupte approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@smith
Copy link
Contributor Author

smith commented Sep 14, 2020

retest

@smith smith requested a review from a team as a code owner September 14, 2020 22:27
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 5.0MB -1.0B 5.0MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Sep 15, 2020

These changes were included in #77248.

@smith smith closed this Sep 15, 2020
@smith smith deleted the nls/feature-fix branch September 15, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @elasticmachine @kibanamachine @ogupte