[Backport] Only proxy whitelisted request headers to ES server upstream #7800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
force-pushed
the
backport-6896-whitelist-headers
branch
from
f6ad886
to
3939ab1
Compare
|
This change can't go into 4.x because it's a backwards compatibility break for Kibana core. We've even tried the approach of modifying callWithRequest to send through all headers (only in 4.x) instead, but that causes other bugs. You can see the trail of destruction in the form of failed backport PRs and linked tickets in the original PR. |
Ah, right, because it's filtering the headers instead of just appending/modifying authorization. Good catch, thanks. After talking to @ycombinator I actually don't think I need to the header filtering stuff in 4.x at all. Pretty sure I can close this and pretend it never happened... |
cee-chen
added a commit
that referenced
this pull request
Jun 3, 2024
`v94.5.2` ⏩ `v94.6.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v94.6.0`](https://github.com/elastic/eui/releases/v94.6.0) - Updated `EuiComboBox` to support rendering `option.append` and `option.prepend` in group labels ([#7800](elastic/eui#7800)) **Accessibility** - Improved the accessibility experience of `EuiBetaBadge` ([#7805](elastic/eui#7805))
rohanxz
pushed a commit
to honeyn303/kibana
that referenced
this pull request
Jun 4, 2024
`v94.5.2` ⏩ `v94.6.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v94.6.0`](https://github.com/elastic/eui/releases/v94.6.0) - Updated `EuiComboBox` to support rendering `option.append` and `option.prepend` in group labels ([elastic#7800](elastic/eui#7800)) **Accessibility** - Improved the accessibility experience of `EuiBetaBadge` ([elastic#7805](elastic/eui#7805))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6896
I really just needed
filter_headers, but I figured I might as well backport the rest of the changes as well.The only part missing is the docs page for the
kibana.ymlsettings, but it looks like that page doesn't exist in 4.x.