Fix KQL autocomplete value suggestions #78676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:KQL
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
mattkime
reviewed
Sep 28, 2020
| const fullFieldName = nestedPath ? `${nestedPath}.${fieldName}` : fieldName; | ||
| const fields = allFields.filter((field) => field.name === fullFieldName); | ||
|
|
||
| const indexPatternFieldEntries: Array<[IIndexPattern, IFieldType]> = []; |
There was a problem hiding this comment.
Just want to make sure these are the correct types. They're necessary if someone is passing in js objects instead of classes instances but otherwise we should use IndexPattern and IndexPatternField
There was a problem hiding this comment.
If we could add that in a follow-up PR I think that'd be ideal since it will also include some refactoring of all the suggestors (value, conjunction, fields, etc.)
lukasolson
force-pushed
the
fix-value-suggestions
branch
from
79b678f
to
2369467
Compare
💔 Build Failed
Failed CI StepsTest FailuresX-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/usage·ts.Reporting APIs Usage from new jobs posted should handle preserve_layout pdfStandard OutStack TraceX-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/usage·ts.Reporting APIs Usage from new jobs posted should handle preserve_layout pdfStandard OutStack TraceMetrics [docs]@kbn/optimizer bundle module count
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
Sep 29, 2020
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Sep 30, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) Fixes for the Ticket 78375 (elastic#79004) [Security] Alert Telemetry for the Security app (elastic#77200) [Search bar] Remove duplicate `popoverProps` (elastic#79025) [Security Solution][Detections] Add rule overrides for single event EQL rules (elastic#78876) [SECURITY_SOLUTION][ENDPOINT] Improve Endpoint Host data generator to also integrate with Ingest (elastic#74305) remove file accidentally checked in (elastic#79005) [ML] DF Analytics creation wizard: replace select input with job type cards with icons (elastic#78872) [Design] A couple fixes for 7.10 (elastic#78801) Fix KQL autocomplete value suggestions (elastic#78676) [Security Solution][Resolver] New mock with cursor (elastic#78863) Embeddables: basic documentation (elastic#78900) [security solution] only import beat_schema when needed (elastic#78708) [Reporting] API Integration tests: fix flaky tests for Spaces CSV formatting (elastic#78849) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) ...
lukasolson
added a commit
that referenced
this pull request
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #75742.
At some point with the index pattern refactorings, things like
name,aggregatable, andtypeweren't properties of thefieldobject, but became accessor methods. Since we were doing some funky transformations in the value suggestions logic, these properties were getting lost as a result of something like this:This PR updates the code to not lose these properties and adds a functional test to ensure value suggestions are working properly.
Checklist