Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PR #7873 to 4.1 #7877

Merged
merged 1 commit into from
Jul 28, 2016
Merged

[backport] PR #7873 to 4.1 #7877

merged 1 commit into from
Jul 28, 2016

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jul 28, 2016

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you included unit tests that cover the changes?
  • If submitting code, have you tested and built your code locally prior to submission with npm test && npm run build?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.

@jbudz jbudz added the backport label Jul 28, 2016
@jbudz jbudz self-assigned this Jul 28, 2016
@epixa
Copy link
Contributor

epixa commented Jul 28, 2016

Seriously though, have you signed the contributor license agreement? Have you followed the contributor guidelines?

@jbudz
Copy link
Member Author

jbudz commented Jul 28, 2016

Whoops my pull request isn't against master, I'm not doing the last bullet point right

@epixa
Copy link
Contributor

epixa commented Jul 28, 2016

Cut it out

@jbudz jbudz merged commit b2fb6cb into elastic:4.1 Jul 28, 2016
@jbudz jbudz deleted the typeahead-4.1 branch July 28, 2016 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants