Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not perform unnecessary round-trip to ES. #7960

Merged
merged 3 commits into from
Aug 11, 2016
Merged

Do not perform unnecessary round-trip to ES. #7960

merged 3 commits into from
Aug 11, 2016

Commits on Aug 9, 2016

  1. Do not perform unnecessary round-trip to ES. 

    If the visualization parameters change, but the query stays intact, we
should not fetch a new query.
    @thomasneirynck
    thomasneirynck committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    3f59e38 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2016

  1. Only refresh when Data-tab has changed 

    The below is a more clear way to express what needs to happen.
This also avoids a bug when there is no re-fetch when there are both
changes in the Options and Data tab.
    @thomasneirynck
    thomasneirynck committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    433c842 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2016

  1. Add tests for jsonDataEquals 

    Also test .toJSON orders properties consistently.
    @thomasneirynck
    thomasneirynck committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    ca6ce25 View commit details
    Browse the repository at this point in the history