Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules #79871

Merged
merged 3 commits into from
Oct 8, 2020
Merged

[Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules #79871

merged 3 commits into from
Oct 8, 2020

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Oct 7, 2020 •
edited
Loading

Summary

Removes list operators (is in list/is not in list) in add and edit exception modals for EQL rule types because they are not yet supported in the Detection Engine

Screen Shot 2020-10-06 at 5 44 11 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added Team:SIEM v8.0.0 Feature:Detection Rules Anything related to Security Solution's Detection Rules labels Oct 7, 2020
@dplumlee dplumlee self-assigned this Oct 7, 2020
@dplumlee dplumlee marked this pull request as ready for review October 7, 2020 18:55
@dplumlee dplumlee requested review from a team as code owners October 7, 2020 18:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@dplumlee
Copy link
Contributor Author

dplumlee commented Oct 7, 2020

@elasticmachine merge upstream

@dplumlee
Copy link
Contributor Author

dplumlee commented Oct 7, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.5MB 10.5MB +548.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd
rylnd approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested adding exceptions to both rule details and from an EQL signal 👍

@dplumlee dplumlee merged commit c900457 into elastic:master Oct 8, 2020
@dplumlee dplumlee deleted the remove-eql-list-exceptions branch October 8, 2020 19:25
@dplumlee dplumlee mentioned this pull request Oct 8, 2020
Merged
dplumlee added a commit to dplumlee/kibana that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Exception Modal] Removes list operators in except…
cc51866 
…ion modal for EQL rules (elastic#79871)
@dplumlee dplumlee mentioned this pull request Oct 8, 2020
Merged
dplumlee added a commit that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Exception Modal] Removes list operators in except…
2d0228b 
…ion modal for EQL rules (#79871) (#80054)
dplumlee added a commit that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Exception Modal] Removes list operators in except…
37135a5 
…ion modal for EQL rules (#79871) (#80055)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 12, 2020
@gmmorris
Merge branch 'master' into task-manager/health
6dddf5c 
* master: (23 commits)
  Table visualization renderer (elastic#79455)
  Migrate Jest JUnit reporter to TS (elastic#79919)
  store sorted bundleRefExportIds (elastic#80011)
  update chromedriver dependency to 86.0.0 (elastic#79972)
  [Security Solution][Case] Fix bug when changing connectors (elastic#80002)
  [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752)
  [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038)
  [Logs UI] Sync logs timerange with wider Kibana (elastic#79444)
  [DOCS] Adds quick start (elastic#78822)
  [Ingest Manager]Fix ingest manager UI renaming (elastic#80036)
  [Monitoring] Fixed internal monitoring check (elastic#79241)
  [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871)
  Update development documentation about REST API best practices (elastic#80009)
  [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190)
  [CI] Move kibana build dir outside of repo for functional tests (elastic#80018)
  [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013)
  [Enterprise Search] Added a Credentials page to App Search (elastic#79749)
  [DOCS] Canvas refresh for 7.10 (elastic#80017)
  [TSVB] Add ignore global filters to series options (elastic#79337)
  Remove this check (elastic#79202)
  ...
@spong spong mentioned this pull request Nov 26, 2020
Closed
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@dplumlee dplumlee

Labels
Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibanamachine @rylnd @MindyRS