Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] 7.10 documentation updates #79917

Merged
merged 14 commits into from
Oct 19, 2020
Merged

[maps] 7.10 documentation updates #79917

merged 14 commits into from
Oct 19, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 7, 2020

This PR updates documentation for 7.10 additions including

  • MVT tiles from elasticsearch
  • auto fit to bounds
  • drilldowns
  • CSV import

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 docs v7.11.0 labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@gchaps
Copy link
Contributor

gchaps commented Oct 7, 2020

To fix the error, go to docs/setup/connect-to-elasticsearch and update the geojson-upload link and remove the image in that section.

docs/maps/maps-getting-started.asciidoc Outdated Show resolved Hide resolved
docs/maps/search.asciidoc Outdated Show resolved Hide resolved
docs/maps/search.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-layer.asciidoc Outdated Show resolved Hide resolved
In order to use your geospatial data in the Elastic Stack, it must be indexed as {ref}/geo-point.html[geo_point] or {ref}/geo-shape.html[geo_shape].
Kibana makes it easy to import geospatial data into the Elastic Stack.

=== Upload a CSV file with latitude and longitude columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [discrete] above this title so that content appears on the same page.

Can you shorten this title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [discrete] above this title so that content appears on the same page.

I have also seen this done with [float]. What is the difference between [discrete] and [float]?

Can you shorten this title?

How about "Upload CSV with latitude and longitude columns"?

[[import-geospatial-data]]
== Import geospatial data

In order to use your geospatial data in the Elastic Stack, it must be indexed as {ref}/geo-point.html[geo_point] or {ref}/geo-shape.html[geo_shape].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intro needs some work. Are CSV Upload and GeoJSON upload two different ways to get your data into Elasticsearch and have it set up correctly?

Maybe this for the first sentence?

Geospatial data in the Elastic Stack must be indexed as a geo_point or geo_shape.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CSV Upload and GeoJSON upload two different ways to get your data into Elasticsearch and have it set up correctly?

Yes


To upload a CSV file with latitude and longitude columns

. Open the Kibana sidebar menu, then click *{kib} > Machine Learning*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Open the Kibana sidebar menu, then click *{kib} > Machine Learning*.
. Open the menu, then click *Machine Learning*.

docs/maps/import-geospatial-data.asciidoc Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
@nreese nreese requested a review from gchaps October 8, 2020 12:30
@nreese nreese requested a review from gchaps October 8, 2020 19:20
@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2020

@elasticmachine merge upstream

docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved
docs/maps/import-geospatial-data.asciidoc Outdated Show resolved Hide resolved

*File Data Visualizer* indexes CSV files with latitude and longitude columns as a geo_point.

. Click *{kib} > Machine Learning* from the side navigation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Click *{kib} > Machine Learning* from the side navigation.
. Open the menu, and click *Machine Learning*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing to "Open the side navigation, and click Machine Learning". "Open the menu" is too vague. There are a log to menus in Kibana and just saying "Open the menu" does not properly direct the user on where to go

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@nreese nreese requested a review from gchaps October 19, 2020 21:27
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit 22c1b9e into elastic:master Oct 19, 2020
nreese added a commit to nreese/kibana that referenced this pull request Oct 19, 2020
* [maps] 7.10 documenation updates

* clean up

* clean up connect-to-elasticsearch reference to renamed page

* Update docs/maps/vector-layer.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* move upload intro sentences into geospatial import block

* improvements to Import geospatial data

* fix typo

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

Co-authored-by: gchaps <[email protected]>
nreese added a commit to nreese/kibana that referenced this pull request Oct 19, 2020
* [maps] 7.10 documenation updates

* clean up

* clean up connect-to-elasticsearch reference to renamed page

* Update docs/maps/vector-layer.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* move upload intro sentences into geospatial import block

* improvements to Import geospatial data

* fix typo

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

Co-authored-by: gchaps <[email protected]>
nreese added a commit that referenced this pull request Oct 19, 2020
* [maps] 7.10 documenation updates

* clean up

* clean up connect-to-elasticsearch reference to renamed page

* Update docs/maps/vector-layer.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* move upload intro sentences into geospatial import block

* improvements to Import geospatial data

* fix typo

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
nreese added a commit that referenced this pull request Oct 19, 2020
* [maps] 7.10 documenation updates

* clean up

* clean up connect-to-elasticsearch reference to renamed page

* Update docs/maps/vector-layer.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* move upload intro sentences into geospatial import block

* improvements to Import geospatial data

* fix typo

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/maps/import-geospatial-data.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 20, 2020
…lout-for-warm-and-cold-tier

* 'master' of github.com:elastic/kibana: (126 commits)
  Add cumulative sum expression function (elastic#80129)
  [APM] Fix link to trace (elastic#80993)
  Provide url rewritten in onPreRouting interceptor (elastic#80810)
  limit renovate to npm packages
  Fix bug in logs UI link (elastic#80943)
  [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343)
  [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list
  docs test (elastic#81080)
  Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067)
  [APM] Fix service map highlighted edge on node select (elastic#80791)
  Fix typo in toast, slight copy adjustment. (elastic#80843)
  [Security Solution] reduce optimizer limits (elastic#80997)
  [maps] 7.10 documentation updates (elastic#79917)
  [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903)
  [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033)
  Upgrade EUI to v29.5.0 (elastic#80753)
  [Maps] Fix layer-flash when changing style (elastic#80948)
  [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220)
  [Enterprise Search] Handle loading state on Credentials page (elastic#80035)
  [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation docs release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants