Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning notification when sorting in asc order by count in term agg #8050

Merged
merged 7 commits into from
Aug 23, 2016
Merged

Show warning notification when sorting in asc order by count in term agg #8050

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48a9b41
Show warning notification when sorting in desc order by count in term…
ycombinator Aug 22, 2016
34f0fce
Removing redundant variable
ycombinator Aug 23, 2016
3d39623
Move notifier instantiation to higher scope
ycombinator Aug 23, 2016
d78eb51
Conditionally place deprecated annotation on select list value itself
ycombinator Aug 23, 2016
fe2a6f8
Removing notification
ycombinator Aug 23, 2016
981ce77
Revert "Removing notification"
ycombinator Aug 23, 2016
dbf2a7d
Revert "Conditionally place deprecated annotation on select list valu…
ycombinator Aug 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/ui/public/agg_types/buckets/terms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import Notifier from 'ui/notify/notifier';

define(function (require) {
return function TermsAggDefinition(Private) {
let _ = require('lodash');
Expand Down Expand Up @@ -130,6 +132,13 @@ define(function (require) {

let orderAgg = agg.params.orderAgg || vis.aggs.getResponseAggById(agg.params.orderBy);

const orderBy = orderAgg.type.name;
const sortOrder = agg.params.order.val;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer sortOrder over dir, but I'm not a fan of two variables tracking the same thing.

if (orderBy === 'count' && sortOrder === 'asc') {
const notify = new Notifier();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this at a higher scope? No reason to recreate it all the time. Perhaps you could also use this as a way to debounce the calls...

notify.warning('Sorting in Ascending order by Count in Terms aggregations is deprecated');
}

// TODO: This works around an Elasticsearch bug the always casts terms agg scripts to strings
// thus causing issues with filtering. This probably causes other issues since float might not
// be able to contain the number on the elasticsearch side
Expand Down