[App Search] Misc credentials key UI enhancements #81817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
Feature:Plugins
release_note:skip
cee-chen
commented
Oct 27, 2020
| @@ -40,6 +40,7 @@ export const CredentialsList: React.FC = () => { | |||
| { | |||
| name: 'Key', | |||
| width: '36%', | |||
| className: 'eui-textBreakAll', | |||
cee-chen
commented
Oct 27, 2020
Comment on lines
64
to
67
| mobileOptions: { | ||
| width: '100%', | ||
| }, |
There was a problem hiding this comment.
Ideally this produces this (much nicer) mobile UI layout:
However - this API isn't in yet. See elastic/eui#4168 as to why the fullWidth: true prop doesn't work.
I'll undraft this PR once elastic/eui#4169 is in Kibana.
JasonStoltz
reviewed
Oct 29, 2020
| @@ -25,7 +25,9 @@ export const HiddenText: React.FC<IProps> = ({ text, children }) => { | |||
| defaultMessage: 'Hidden text', | |||
| }); | |||
| const hiddenText = isHidden ? ( | |||
| <span aria-label={hiddenLabel}>{text.replace(/./g, '•')}</span> | |||
| <span aria-label={hiddenLabel}> | |||
JasonStoltz
approved these changes
Oct 29, 2020
cee-chen
force-pushed
the
credential-table-enhancements
branch
2 times, most recently
from
5d17432
to
e892487
Compare
cee-chen
force-pushed
the
credential-table-enhancements
branch
from
e892487
to
b8a97e3
Compare
JasonStoltz
approved these changes
Dec 22, 2020
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I was doing a final QA pass of the credentials view, I noticed some minor UI/UX things that were bugging me a little, so I tackled them in a separate commit 😅 Screencaps will be listed below on individual commits.
This is a Draft PR because the last commit is still waiting to use a recent EUI change. I'll un-draft the PR once Kibana updates to it. @JasonStoltz I'm assigning to you mostly as an FYI and to get your early eyes on it in case you have any thoughts!
Checklist