Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce saved objects authorization checks #82204

Merged
merged 8 commits into from
Nov 4, 2020
Merged

Reduce saved objects authorization checks #82204

merged 8 commits into from
Nov 4, 2020

Conversation

jportner
Copy link
Contributor

Resolves #82203.

@jportner jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 30, 2020
@jportner jportner requested a review from legrego October 30, 2020 21:28
@jportner jportner requested a review from a team as a code owner October 30, 2020 21:28
@jportner
Copy link
Contributor Author

jportner commented Nov 2, 2020

@elasticmachine merge upstream

@legrego legrego self-requested a review November 4, 2020 00:48
@legrego
Copy link
Member

legrego commented Nov 4, 2020

@elasticmachine merge upstream

legrego
legrego approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

x-pack/plugins/security/server/saved_objects/secure_saved_objects_client_wrapper.test.ts
@@ -1153,4 +1161,41 @@ describe('other', () => {
test(`assigns errors from constructor to .errors`, () => {
expect(client.errors).toBe(clientOpts.errors);
});

test(`namespace redaction fails safe`, async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 92100f2 into elastic:master Nov 4, 2020
@jportner jportner deleted the issue-82203-saved-objects-authz-checks branch November 4, 2020 19:13
@jportner jportner mentioned this pull request Nov 4, 2020
Merged
jportner added a commit to jportner/kibana that referenced this pull request Nov 4, 2020
@jportner
Reduce saved objects authorization checks (elastic#82204)
4470a90
jportner added a commit that referenced this pull request Nov 4, 2020
@jportner
Reduce saved objects authorization checks (#82204) (#82649)
eee8542
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 5, 2020
@gmmorris
Merge branch 'master' into alerts/assign-action-groups
2730301 
* master: (127 commits)
  [ILM] Fix breadcrumbs (elastic#82594)
  [UX]Swap env filter with percentile (elastic#82246)
  Add platform's missing READMEs (elastic#82268)
  [Discover] Adding uiMetric to track Visualize link click (elastic#82344)
  [Search] Add used index pattern name to the search agg error field (elastic#82604)
  improve client-side SO client get pooling (elastic#82603)
  [Security Solution] Unskips Overview tests (elastic#82459)
  Embeddables/migrations (elastic#82296)
  [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663)
  Moving reinstall function outside of promise.all (elastic#82672)
  Load choropleth layer correctly (elastic#82628)
  Master  backport elastic#81233 (elastic#82642)
  [Fleet] Allow snake cased Kibana assets (elastic#77515)
  Reduce saved objects authorization checks (elastic#82204)
  [data.search] Add request handler context and asScoped pattern (elastic#80775)
  [ML] Fixes formatting of fields in index data visualizer (elastic#82593)
  Usage collector readme (elastic#82548)
  [Lens] Visualization validation and better error messages (elastic#81439)
  [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490)
  chore(NA): install microdnf in UBI docker build only (elastic#82611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backported release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid redundant saved objects authorization checks
3 participants
@jportner @legrego @kibanamachine