Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advanced settings category sorting #83394

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix advanced settings category sorting #83394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/plugins/advanced_settings/public/management_app/lib/get_category_name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ const names: Record<string, string> = {
general: i18n.translate('advancedSettings.categoryNames.generalLabel', {
defaultMessage: 'General',
}),
machineLearning: i18n.translate('advancedSettings.categoryNames.machineLearningLabel', {
defaultMessage: 'Machine Learning',
}),
observability: i18n.translate('advancedSettings.categoryNames.observabilityLabel', {
defaultMessage: 'Observability',
}),
timelion: i18n.translate('advancedSettings.categoryNames.timelionLabel', {
defaultMessage: 'Timelion',
}),
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/apm/server/ui_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
*/
export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
[enableCorrelations]: {
category: ['Observability'],
category: ['observability'],
name: i18n.translate('xpack.apm.enableCorrelationsExperimentName', {
defaultMessage: 'APM Correlations',
}),
Expand All @@ -32,7 +32,7 @@ export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
schema: schema.boolean(),
},
[enableServiceOverview]: {
category: ['Observability'],
category: ['observability'],
name: i18n.translate('xpack.apm.enableServiceOverviewExperimentName', {
defaultMessage: 'APM Service overview',
}),
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/ml/server/lib/register_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function registerKibanaSettings(coreSetup: CoreSetup) {
defaultMessage:
'Sets the file size limit when importing data in the File Data Visualizer. The highest supported value for this setting is 1GB.',
}),
category: ['Machine Learning'],
category: ['machineLearning'],
schema: schema.string(),
validation: {
regexString: '\\d+[mMgG][bB]',
Expand All @@ -49,7 +49,7 @@ export function registerKibanaSettings(coreSetup: CoreSetup) {
'Use the default time filter in the Single Metric Viewer and Anomaly Explorer. If not enabled, the results for the full time range of the job are displayed.',
}
),
category: ['Machine Learning'],
category: ['machineLearning'],
},
[ANOMALY_DETECTION_DEFAULT_TIME_RANGE]: {
name: i18n.translate('xpack.ml.advancedSettings.anomalyDetectionDefaultTimeRangeName', {
Expand All @@ -69,7 +69,7 @@ export function registerKibanaSettings(coreSetup: CoreSetup) {
to: schema.string(),
}),
requiresPageReload: true,
category: ['Machine Learning'],
category: ['machineLearning'],
},
});
}