-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES client : use the new type definitions #83808
Merged
Merged
Changes from 159 commits
Commits
Show all changes
178 commits
Select commit
Hold shift + click to select a range
9fa2b78
Use client from branch
joshdover d2ae74f
Get type checking working in core
joshdover 5106b09
Fix types in other plugins
joshdover be34ba1
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover 6710f81
Update client types + remove type errors from core
joshdover 491bd11
migrate Task Manager Elasticsearch typing from legacy library to clie…
gmmorris 3f179b2
use SortOrder instead o string in alerts
gmmorris a7fc04b
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover 6d99c9c
Update client types + fix core type issues
joshdover 7f153ae
fix maps ts errors
nreese f2a3c9d
Update Lens types
wylieconlon a37f2e4
Convert Search Profiler body from a string to an object to conform to…
cjcenizal 58d23f3
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover 9057ce7
Fix SOT types
joshdover 526e8ed
Fix/mute Security/Spaces plugins type errors.
azasypkin 0c08a52
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover 8e8fc8f
Fix bootstrap types
joshdover 74845ce
Fix painless_lab
joshdover 2b34470
corrected es typing in Event Log
gmmorris 4930e35
Use new types from client for inferred search responses
dgieselaar 9a58724
Latest type defs
dgieselaar 6b71705
Integrate latest type defs for APM/UX
dgieselaar 3d03c93
Merge branch 'master' of github.com:elastic/kibana into new-types-client
dgieselaar b6d5263
fix core errors
mshustov 422ee42
fix telemetry errors
mshustov b9c7fd5
fix canvas errors
mshustov 47a0995
fix data_enhanced errors
mshustov 0809609
fix event_log errors
mshustov 6d488ab
mute lens errors
mshustov 790a219
fix or mute maps errors
mshustov 0287242
fix reporting errors
mshustov f7a1f72
fix security errors
mshustov b8196eb
mute errors in task_manager
mshustov 674c257
fix errors in telemetry_collection_xpack
mshustov 3f94cb7
merge master, fix conflicts
mshustov 8cfe69e
fix errors in data plugins
mshustov 2ac0615
fix errors in alerts
mshustov 5caca1c
mute errors in index_management
mshustov f9135fd
fix task_manager errors
mshustov a5a6e36
mute or fix lens errors
mshustov 63624b0
fix upgrade_assistant errors
mshustov 3c6c7c6
fix or mute errors in index_lifecycle_management
mshustov 938fc56
fix discover errors
mshustov 5748581
fix core tests
mshustov a03e3d8
Merge branch 'master' into pr/83808
mshustov 354caf0
ML changes
jgowdyelastic 85f8e57
Merge branch 'master' into pr/83808
mshustov f01ce44
fix core type errors
mshustov 3ebcd33
mute error in kbn-es-archiver
mshustov 23eea1f
fix error in data plugin
mshustov 718321a
fix error in telemetry plugin
mshustov 52f9bd6
fix error in discover
mshustov dd3a903
fix discover errors
mshustov 39ef08b
fix errors in task_manager
mshustov 34ca800
fix security errors
mshustov ed39ba6
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov d72a12a
fix wrong conflict resolution
mshustov ac51d55
address errors with upstream code
mshustov c85315b
Merge branch 'master' into pr/83808
mshustov 23e027f
update deps to the last commit
mshustov 00a0b26
remove outdated comments
mshustov 87f61de
fix core errors
mshustov edc2009
fix errors after update
mshustov a09d2e1
adding more expect errors to ML
jgowdyelastic a0f5a96
pull the lastest changes
mshustov 4fa0d64
fix core errors
mshustov b12dd76
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov 4ba54cf
fix errors in infra plugin
mshustov 60a71af
fix errors in uptime plugin
mshustov ce6cebf
fix errors in ml
mshustov 7a88144
fix errors in xpack telemetry
mshustov fdc4042
fix or mute errors in transform
mshustov 52cf5d6
fix errors in upgrade assistant
mshustov 4ca74c6
fix or mute fleet errors
mshustov 2424c67
start fixing apm errors
mshustov 9e3e5e7
fix errors in osquery
mshustov d4d6762
fix telemetry tests
mshustov 86f3892
core cleanup
mshustov 372233d
fix asMutableArray imports
mshustov 5287fd6
cleanup
mshustov 83f3966
data_enhanced cleanup
mshustov bb51050
cleanup events_log
mshustov 1ed809f
cleaup
mshustov dca9d22
fix error in kbn-es-archiver
mshustov eeb7dbb
fix errors in kbn-es-archiver
mshustov 07ed8d2
Merge branch 'master' into pr/83808
mshustov 21df2c5
fix errors in kbn-es-archiver
mshustov d2e42aa
fix ES typings for Hit
mshustov 51bc200
fix SO
mshustov 1b99cf9
fix actions plugin
mshustov bc7a72e
fix fleet
mshustov c2d4bef
fix maps
mshustov 2751c08
fix stack_alerts
mshustov 6f8ccb5
fix eslint problems
mshustov ed95ce4
fix event_log unit tests
mshustov 2e1842d
fix failures in data_enhanced tests
mshustov 7adc3fd
fix test failure in kbn-es-archiver
mshustov 74f670b
fix test failures in index_pattern_management
mshustov 91ceb57
fixing ML test
jgowdyelastic 7392e9f
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov d701a8b
Merge branch 'master' into pr/83808
mshustov 4ea862d
remove outdated comment in kbn-es-archiver
mshustov 1b68394
fix error type in ml
mshustov c1802e4
fix eslint errors in osquery plugin
mshustov 0e3d505
fix runtime error in infra plugin
mshustov 74b969a
revert changes to event_log cluser exist check
mshustov f30a0de
fix eslint error in osquery
mshustov f6eee91
Merge branch 'master' into pr/83808
mshustov 209cf9f
fixing ML endpoint argument types
jgowdyelastic 8b0257f
fx types
joshdover 830ebf2
Update api-extractor docs
joshdover f8d3375
attempt fix for ese test
joshdover 108fe4a
Fix lint error
dgieselaar f434eac
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover c911c1c
Fix types for ts refs
joshdover 3029696
Fix data_enhanced unit test
joshdover 24e60f6
fix lens types
joshdover f080be4
generate docs
joshdover 3934f75
Fix a number of type issues in monitoring and ml
joshdover 1d0d51b
fix triggers_actions_ui
joshdover 7bf6525
Fix ILM functional test
joshdover 506a0d4
Merge remote-tracking branch 'upstream/master' into new-types-client
joshdover 2f40484
Put search.d.ts typings back
joshdover 1abb229
fix data plugin
joshdover 8016d3c
Update typings in typings/elasticsearch
dgieselaar cc51172
Update snapshots
dgieselaar 823a611
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov 935a83f
Merge branch 'master' into pr/83808
mshustov ad61d56
mute errors in task_manager
mshustov d9927dc
mute fleet errors
mshustov 1205e0e
lens. remove unnecessary ts-expect-errors
mshustov d23a93f
fix errors in stack_alerts
mshustov 954b7b7
mute errors in osquery
mshustov 83b55e5
fix errors in security_solution
mshustov cd53d75
fix errors in lists
mshustov 334c431
fix errors in cases
mshustov 803a2aa
Merge branch 'master' into pr/83808
mshustov c74ac8c
mute errors in search_examples
mshustov 30d799f
use KibanaClient to enforce promise-based API
mshustov 76a89af
fix errors in test/ folder
mshustov 6f9818a
update comment
mshustov b32f888
fix errors in x-pack/test folder
mshustov 0cebacc
Merge branch 'master' into pr/83808
mshustov 2a867c4
fix errors in ml plugin
mshustov 1255acc
fix optional fields in ml api_integartoon tests
mshustov 0ba26ec
fix another casting problem in ml tests
mshustov e3d185b
fix another ml test failure
mshustov 0ed4917
Merge branch 'master' into pr/83808
mshustov 55ad083
fix fleet problem after conflict resolution
mshustov 9627c47
rollback changes in security_solution. trying to fix test
mshustov 77544d5
Update type for discover rows
wylieconlon 1cd710b
uncomment runtime_mappings as its outdated
mshustov c6b7bef
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov b54e736
address comments from Wylie
mshustov 0a09cc9
remove eslint error due to any
mshustov fe3f03a
mute error due to incompatibility
mshustov ddb61c1
Apply suggestions from code review
mshustov eda8d8b
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov 7974cfa
fix type error in lens tests
mshustov e85c3d4
Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex…
mshustov 3e537f1
Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex…
mshustov e0553da
update deps
mshustov a0ecaf9
fix errors in core types
mshustov a958e93
fix errors for the new elastic/elasticsearch version
mshustov 8da818a
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov 078b186
remove unused type
mshustov d8506bb
remove unnecessary manual type cast and put optional chaining back
mshustov 60951ec
Merge branch 'master' into pr/83808
mshustov d2e04f3
ML: mute Datafeed is missing indices_options
mshustov 3879242
Apply suggestions from code review
mshustov 37bac07
Merge remote-tracking branch 'delvedor/new-types-client' into pr/83808
mshustov c0e1640
use canary pacakge instead of git commit
mshustov b83b2d2
Merge branch 'master' into pr/83808
mshustov 80f730e
Merge branch 'master' into pr/83808
mshustov 370c5db
Merge branch 'master' into pr/83808
mshustov 815edf0
Merge branch 'master' into pr/83808
mshustov f353538
Merge branch 'master' into pr/83808
mshustov b65f197
Merge branch 'master' into pr/83808
mshustov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,5 @@ | |
<b>Signature:</b> | ||
|
||
```typescript | ||
sortOrder?: string; | ||
sortOrder?: estypes.SortOrder; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,5 @@ | |
<b>Signature:</b> | ||
|
||
```typescript | ||
sortOrder?: string; | ||
sortOrder?: estypes.SortOrder; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ | |
|
||
export const ES_CLIENT_HEADERS = { | ||
'x-elastic-product-origin': 'kibana', | ||
}; | ||
} as const; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any context on this change? Plans for version management?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a temporary measurement. We are going to release another canary package when this PR is approved.