Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Migrate Source containers and routers #83954

Merged
merged 14 commits into from
Nov 23, 2020
Merged

[Workplace Search] Migrate Source containers and routers #83954

merged 14 commits into from
Nov 23, 2020

Commits on Nov 19, 2020

  1. Initial copy/paste of components 

    No changes other than linting and the removal of the underscore.toSentenceSerial method in favor of the following:

new Intl.ListFormat().format(groups)

which does the same thing
    @scottybollinger
    scottybollinger committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    66e8a89 View commit details
    Browse the repository at this point in the history

  2. Redo groups sentence with more accepted solution 

    Turns out the previos commit’s solution is not widely accepted:

https://caniuse.com/?search=ListFormat
    @scottybollinger
    scottybollinger committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    6e72a37 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Add placeholders for future components 

    Schema and DisplaySettings are Custom Source components that will be added later. These are stubs so the containers will render.
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d90502a View commit details
    Browse the repository at this point in the history

  2. Update component paths

    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b985960 View commit details
    Browse the repository at this point in the history

  3. Remove AppView, SidebarNavigation and FlashMessages 

    Sidebar copy and breadcrumbs will be recreated at the top level in a separate PR
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    771f909 View commit details
    Browse the repository at this point in the history

  4. Use Kibana’s hasPlatinumLicense over minimumPlatinumLicense 

    Also renames fpAccount to account, as it’s called in Kibana
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b8c2c64 View commit details
    Browse the repository at this point in the history

  5. Fix typings

    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    9acf048 View commit details
    Browse the repository at this point in the history

  6. Move sidebar content temporarily to top of page 

    This is temporary as noted by comments
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    18807b4 View commit details
    Browse the repository at this point in the history

  7. Fix missing images

    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    ab31157 View commit details
    Browse the repository at this point in the history

  8. Fix routes 

    Had the base route and not the status route in the fetchSourceStatuses method
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    6335dfb View commit details
    Browse the repository at this point in the history

  9. Clean up last Sidebar with temp copy placement 

    This is so that CI will pass and we can get this merged in and do the actual wiring up of everything in a separate PR.
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    0d8940a View commit details
    Browse the repository at this point in the history

  10. Remove unused links 

    For CI to pass. Will add back in future PR
    @scottybollinger
    scottybollinger committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    e115971 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Merge branch 'master' into scottybollinger/sources-root

    @kibanamachine
    kibanamachine authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    95466c7 View commit details
    Browse the repository at this point in the history

  2. Minify SVG illustration

    @scottybollinger
    scottybollinger committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    a6d7036 View commit details
    Browse the repository at this point in the history