-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate security routes to a new Elasticsearch client. #84528
Conversation
@@ -185,6 +185,7 @@ export class Plugin { | |||
taskManager, | |||
}); | |||
|
|||
core.getStartServices().then(([{ elasticsearch }]) => elasticsearch.client); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
if (apiResponse) { | ||
mockScopedClusterClient.callAsCurrentUser.mockImplementation(apiResponse); | ||
mockContext.core.elasticsearch.client.asCurrentUser.security.getApiKey.mockImplementation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: it's not really easy to use these mocks as the signature requires many other fields in addition to body
.
Pinging @elastic/kibana-security (Team:Security) |
964f4ce
to
a5b198c
Compare
@thomheymann thanks for taking this review! ❤️ |
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/cloning·ts.machine learning data frame analytics jobs cloning supported by UI form classification job supported by the form runs the clone analytics job and displays it correctly in the job listStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that all instances of callAsCurrentUser
have been migrated and new implementation follow migration guidelines.
LGTM!
7.x/7.11.0: 6665f27 |
We should eventually remove all dependencies on the Legacy ES Client, and in this PR I migrated all our routes to use new ES client.
Related to: #83910