Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] allow drag and drop reorder on xyChart for y dimension #84640

Merged
merged 10 commits into from
Dec 3, 2020
Merged

[Lens] allow drag and drop reorder on xyChart for y dimension #84640

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d678acb
[Lens] allow drag and drop on xyChart for y dimension
mbondyra Dec 1, 2020
5284ca5
Merge branch 'master' into lens/drag_n_drop_for_xy
kibanamachine Dec 1, 2020
a5eaaff
wip
mbondyra Dec 2, 2020
0d13d11
Merge branch 'lens/drag_n_drop_for_xy' of https://github.com/mbondyra…
mbondyra Dec 2, 2020
eaf5918
Merge commit 'cbc61afcce023d0478784c953d092e4b8dd9a375' into lens/dra…
mbondyra Dec 2, 2020
e1258ed
tests
mbondyra Dec 2, 2020
1241d81
dimension panel fix
mbondyra Dec 3, 2020
aff9415
eslint
mbondyra Dec 3, 2020
3a9a556
Merge commit '17d986e499f9877c28063fce1e941e25e04b7024' into lens/dra…
mbondyra Dec 3, 2020
8e3203f
fix test
mbondyra Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ export function LayerPanel(
const isFromTheSameGroup =
isDraggedOperation(dragging) &&
dragging.groupId === group.groupId &&
dragging.columnId !== accessor &&
dragging.groupId !== 'y'; // TODO: remove this line when https://github.com/elastic/elastic-charts/issues/868 is fixed
dragging.columnId !== accessor;

const isDroppable = isDraggedOperation(dragging)
? dragType === 'reorder'
Expand Down