Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for server.host to be set in development #8487

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

tylersmalley
Copy link
Contributor

Since Kibana now defaults to localhost, it's often needed to bind to all network addresses or a specific hostname.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will cause "invalid cert" errors when the host is set but ssl isn't disabled or updated to match the new hostname, but that's not necessarily a bad thing.

@spalger spalger merged commit e78c829 into elastic:master Oct 4, 2016
elastic-jasper added a commit that referenced this pull request Oct 4, 2016
---------

**Commit 1:**
Allows for server.host to be set in development

Signed-off-by: Tyler Smalley <[email protected]>

* Original sha: 7d76e68
* Authored by Tyler Smalley <[email protected]> on 2016-09-28T06:42:11Z
elastic-jasper added a commit that referenced this pull request Oct 4, 2016
---------

**Commit 1:**
Allows for server.host to be set in development

Signed-off-by: Tyler Smalley <[email protected]>

* Original sha: 7d76e68
* Authored by Tyler Smalley <[email protected]> on 2016-09-28T06:42:11Z
epixa added a commit that referenced this pull request Oct 4, 2016
[backport] PR #8487 to 5.x - Allows for server.host to be set in development
epixa added a commit that referenced this pull request Oct 4, 2016
[backport] PR #8487 to 5.0 - Allows for server.host to be set in development
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
Allows for server.host to be set in development

Signed-off-by: Tyler Smalley <[email protected]>

* Original sha: 735028b2a7bfc6b31ca422f46b2f5503c67c62e9 [formerly 7d76e68]
* Authored by Tyler Smalley <[email protected]> on 2016-09-28T06:42:11Z


Former-commit-id: a08d3a8
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[backport] PR elastic#8487 to 5.x - Allows for server.host to be set in development

Former-commit-id: 773032b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants