Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GS] adding tags UI to search results #85084

Merged
merged 1 commit into from
Dec 10, 2020
Merged

[GS] adding tags UI to search results #85084

merged 1 commit into from
Dec 10, 2020

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Dec 4, 2020 •
edited
Loading

Summary

Closes #81846

🎉 Tags will render on the right hand side of search results.

Screen Shot 2020-12-04 at 17 56 51

😢 It can kind of break if you go really crazy with tags though...
Screen Shot 2020-12-04 at 18 11 56

🤷‍♂️ But I'm not sure how worried we should be of such an extreme case because even still "a lot" of tags looks fine....
Screen Shot 2020-12-07 at 16 58 02

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@myasonik myasonik added release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.11.0 labels Dec 4, 2020
@myasonik myasonik requested a review from a team as a code owner December 4, 2020 23:23
@myasonik myasonik requested a review from a team December 4, 2020 23:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@myasonik
Copy link
Contributor Author

myasonik commented Dec 4, 2020

It can kind of break if you go really crazy with tags though...

@ryankeairns Any ideas on a good way to fix this? (With the soft reminder that we're getting oftly close to feature freeze so the trickier the fix, the less chance it'll merge in time.)

@ryankeairns
Copy link
Contributor

It can kind of break if you go really crazy with tags though...

@ryankeairns Any ideas on a good way to fix this? (With the soft reminder that we're getting oftly close to feature freeze so the trickier the fix, the less chance it'll merge in time.)

I'm not certain what effect (if any) wrapping these in an EuiBageGroup (docs) would have, but I do think we would want to limit the width of the tags section right side content to 50% max (perhaps less) since the Title seems of paramount importance.

I'll take a look later today, but those are my initial thoughts.

@myasonik myasonik mentioned this pull request Dec 7, 2020
Closed
@myasonik myasonik requested a review from a team as a code owner December 8, 2020 00:37
@MichaelMarcialis

This comment has been minimized.

Sign in to view
@ryankeairns

This comment has been minimized.

Sign in to view
@myasonik

This comment has been minimized.

Sign in to view
@ryankeairns

This comment has been minimized.

Sign in to view
@ryankeairns

This comment has been minimized.

Sign in to view
@ryankeairns

This comment has been minimized.

Sign in to view
pgayvallet
pgayvallet approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will do some cleanup in the search bar component file once this PR and #85144 are merged. This file is becoming a mess 😅

x-pack/plugins/saved_objects_tagging/public/utils.test.ts Show resolved Hide resolved
x-pack/plugins/global_search_providers/server/providers/saved_objects/provider.test.ts Outdated Show resolved Hide resolved
.../plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.test.ts Outdated Show resolved Hide resolved
@alexfrancoeur alexfrancoeur mentioned this pull request Dec 9, 2020
Closed
@ryankeairns
Copy link
Contributor

@myasonik I just fired this up and it does not seem to be restricting to 3 tags.

The mobile hiding of tags works as expected, thank you.

@ryankeairns
Copy link
Contributor

This is looking really nice!

The only little hiccup I'm seeing now is that the tags seem to be case sensitive. I thought Pierre addressed this in his PR, so perhaps this is just out of date? For example, I have a Red tag, but typing tag:red returns no results (and no suggestion).

@myasonik
Copy link
Contributor Author

myasonik commented Dec 9, 2020

@pgayvallet I've got no idea what I broke or how... Can you lend a hand?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsTagging 115.6KB 115.6KB -5.0B

Distributable file count

id before after diff
default 46984 47744 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 48.6KB 53.4KB +4.9KB
savedObjectsTagging 49.1KB 49.5KB +396.0B
total +5.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet
Copy link
Contributor

The only little hiccup I'm seeing now is that the tags seem to be case sensitive. I thought Pierre addressed this in his PR, so perhaps this is just out of date? For example, I have a Red tag, but typing tag:red returns no results (and no suggestion).

Actually it doesn't, even on master.

What I did is that if you have a Red tag and you type red, the tag:red suggestion will be displayed.

However, the logic retrieving tags by their name always was case sensitive. So tag:red will not 'find' the Red tag. I think we do need to fix that, but this was not introduced by @myasonik's PR.

ryankeairns
ryankeairns approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge based upon Pierre's reply regarding case sensitivity.
We can track that fix separately.

@ryankeairns ryankeairns mentioned this pull request Dec 10, 2020
Closed
@myasonik myasonik merged commit 3652595 into elastic:master Dec 10, 2020
@myasonik myasonik deleted the search-tags-ui branch December 10, 2020 17:16
@myasonik myasonik mentioned this pull request Dec 10, 2020
Merged
myasonik pushed a commit to myasonik/kibana that referenced this pull request Dec 10, 2020
@ryankeairns
[GS] adding tags UI to search results (elastic#85084)
c57991e 
Co-authored-by: Ryan Keairns <[email protected]>
myasonik pushed a commit that referenced this pull request Dec 10, 2020
@ryankeairns
[7.x] [GS] adding tags UI to search results (#85084) (#85610)
64dbd2e 
Co-authored-by: Ryan Keairns <[email protected]>
@alexfrancoeur alexfrancoeur mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@alexfrancoeur alexfrancoeur Awaiting requested review from alexfrancoeur

Assignees
No one assigned
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate tags to navigational search results
6 participants
@myasonik @elasticmachine @ryankeairns @MichaelMarcialis @kibanamachine @pgayvallet