Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Detections] Update read-only callouts from warning to info so they persist when dismissed (#84904) #86047

Merged
merged 1 commit into from
Dec 16, 2020

Commits on Dec 15, 2020

  1. [Security Solution][Detections] Update read-only callouts from warnin…

    …g to info so they persist when dismissed (elastic#84904)
    
    **Addresses:** elastic#76587
    
    ## Summary
    
    In this PR I'm doing basically 2 things:
    
    1. Making readonly callouts we have in Detections `primary` instead of `warning` and thus persistable in local storage (if a callout is dismissed, we remember it there)
    2. Creating a reusable implementation for that.
    
    TODO:
    
    - [x] Adjust all callouts used in Detections to be of type `primary`
    - [x] Implement the local storage logic (dumb)
    - [x] Implement the local storage logic (reusable)
    - [x] Add a new user role: "Reader" (read-only user)
    - [x] Add Cypress tests
    
    Out of scope:
    
    - Add unit tests. I'll probably address this in a follow-up PR. Do you think it's worth it or better to wait until the rework (see the next point)?
    - Rework callouts to standardise them across Detections, Cases and other parts of the Security app? See my comment below in this PR.
    
    ## Screen recordings
    
    Quick demo of how this implementation works:
    
    - [primary callouts](https://drive.google.com/file/d/1SYQd_ihKPvzlVUxELI8qNEqLBOkL18Gd/view?usp=sharing)
    - [warning, danger](https://drive.google.com/file/d/1lrAFPyXNjOYSiEsUXxY_fjXsvmyDcdWY/view?usp=sharing) (callout types here were manually adjusted)
    
    ## Additional notes
    
    Cypress tests are based on the work done in elastic#81866.
    
    ![](https://puu.sh/GXwOd/1c855cb03f.png)
    banderror committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    68a99ca View commit details
    Browse the repository at this point in the history