Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): move maps plugin test fixtures out of __tests__ folder #87764

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 8, 2021

It moves the second item of #85513 forward as it moves maps tests out of tests folder into our common setup for tests run with jest.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested review from thomasneirynck and removed request for thomasneirynck January 8, 2021 00:27
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, thanks you @mistic

@mistic
Copy link
Member Author

mistic commented Jan 11, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 183cf56 into elastic:master Jan 11, 2021
mistic added a commit to mistic/kibana that referenced this pull request Jan 11, 2021
…astic#87764)

* chore(NA): move maps plugin test fixtures out of __tests__ folder

* chore(NA): last missing __tests__ folders renamed

Co-authored-by: Kibana Machine <[email protected]>
mistic added a commit to mistic/kibana that referenced this pull request Jan 11, 2021
…astic#87764)

* chore(NA): move maps plugin test fixtures out of __tests__ folder

* chore(NA): last missing __tests__ folders renamed

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_docs.pbf
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_asgrid.pbf
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_aspoint.pbf
@mistic
Copy link
Member Author

mistic commented Jan 11, 2021

7.x/7.12: 965d775
7.11/7.11.1: 93e2d82

mistic added a commit that referenced this pull request Jan 12, 2021
…7764) (#87875)

* chore(NA): move maps plugin test fixtures out of __tests__ folder

* chore(NA): last missing __tests__ folders renamed

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
mistic added a commit that referenced this pull request Jan 12, 2021
…der (#87764) (#87880)

* chore(NA): move maps plugin test fixtures out of __tests__ folder (#87764)

* chore(NA): move maps plugin test fixtures out of __tests__ folder

* chore(NA): last missing __tests__ folders renamed

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_docs.pbf
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_asgrid.pbf
#	x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_aspoint.pbf

* test(NA): fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants