Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega Docs] Add experimental flag on the vega maps title #89402

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 27, 2021

Summary

This PR fixes a title that is not displayed well and also adds the experiment[] flag on the vega maps first paragraph. You can view the docs change here: https://kibana_89402.docs-preview.app.elstc.co/guide/en/kibana/master/vega.html#vega-with-a-map

The reason I added it there is that the experiment warning is not at the beginning of the section so it is not so visible. We want to be clear to the users that vega maps are not GA.

@KOTungseth @gchaps wdyt?

Wrong title before:
Screenshot 2021-01-27 at 1 07 37 PM

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Stratoula!

@KOTungseth KOTungseth added 7.11 release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 labels Jan 27, 2021
@stratoula stratoula marked this pull request as ready for review January 27, 2021 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@stratoula stratoula merged commit 0abf45f into elastic:master Jan 27, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Jan 27, 2021
* [Vega Docs] Add experimental flag on the vega maps title

* Add the experimental warning on the initial paragraph of vega maps to be more visible
stratoula added a commit that referenced this pull request Jan 27, 2021
…9428)

* [Vega Docs] Add experimental flag on the vega maps title

* Add the experimental warning on the initial paragraph of vega maps to be more visible
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 27, 2021
…y-tests

* 'master' of github.com:elastic/kibana: (276 commits)
  [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675)
  [CI] Combines Jest test jobs (elastic#85850)
  [Upgrade Assistant] Migrate server to new es-js client (elastic#89207)
  Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351)
  [Vega Docs] Add experimental flag on the vega maps title (elastic#89402)
  Increase the time needed to locate the save viz toast (elastic#89301)
  [Enterprise Search] Add links to doc links service (elastic#89260)
  Fixed regex bug in Safari (elastic#89399)
  [Lens] Fix indexpattern checks for missing references (elastic#88840)
  [Lens] Clean up usage collector (elastic#89109)
  update apm index pattern (elastic#89395)
  [APM] Upgrade ES client (elastic#86594)
  Enable v2 so migrations, disable in FTR tests (elastic#89297)
  [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699)
  Cleanup OSS code from visualizations wizard (elastic#89092)
  [APM] Optimize API test order (elastic#88654)
  Rename conversion function, extract to module scope and add tests. (elastic#89018)
  [core.logging] Add ops logs to the KP logging system (elastic#88070)
  chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333)
  skip flaky suite (elastic#89379)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx
#	x-pack/test/accessibility/config.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 27, 2021
…ana into task-manager/shift-on-trend

* 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits)
  [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299)
  [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675)
  [CI] Combines Jest test jobs (elastic#85850)
  [Upgrade Assistant] Migrate server to new es-js client (elastic#89207)
  Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351)
  [Vega Docs] Add experimental flag on the vega maps title (elastic#89402)
  Increase the time needed to locate the save viz toast (elastic#89301)
  [Enterprise Search] Add links to doc links service (elastic#89260)
  Fixed regex bug in Safari (elastic#89399)
  [Lens] Fix indexpattern checks for missing references (elastic#88840)
  [Lens] Clean up usage collector (elastic#89109)
  update apm index pattern (elastic#89395)
  [APM] Upgrade ES client (elastic#86594)
  Enable v2 so migrations, disable in FTR tests (elastic#89297)
  [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699)
  Cleanup OSS code from visualizations wizard (elastic#89092)
  [APM] Optimize API test order (elastic#88654)
  Rename conversion function, extract to module scope and add tests. (elastic#89018)
  [core.logging] Add ops logs to the KP logging system (elastic#88070)
  chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333)
  ...
KOTungseth pushed a commit to KOTungseth/kibana that referenced this pull request Jan 28, 2021
* [Vega Docs] Add experimental flag on the vega maps title

* Add the experimental warning on the initial paragraph of vega maps to be more visible
KOTungseth added a commit that referenced this pull request Jan 29, 2021
…9595)

* [Vega Docs] Add experimental flag on the vega maps title

* Add the experimental warning on the initial paragraph of vega maps to be more visible

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants