Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time to Visualize] Combine Discard & Cancel #91267

Merged
merged 5 commits into from
Feb 16, 2021
Merged

[Time to Visualize] Combine Discard & Cancel #91267

merged 5 commits into from
Feb 16, 2021

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Feb 12, 2021 •
edited
Loading

Summary

This PR recombines the Discard and Cancel buttons into one cancel button with 3 options. see discussion #90320
Screen Shot 2021-02-11 at 8 41 28 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 Project:TimeToVisualize v7.12.0 labels Feb 12, 2021
@cqliu1 cqliu1 mentioned this pull request Feb 12, 2021
Closed
8 tasks
@ThomThomson ThomThomson changed the title [Time to Visualize] Dashboard Top Nav Rework [Time to Visualize] Combine Discard & Cancel Feb 14, 2021
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review February 14, 2021 15:50
@ThomThomson ThomThomson requested a review from a team as a code owner February 14, 2021 15:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

clintandrewhall
clintandrewhall approved these changes Feb 14, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me...! 🚢

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 178.4KB 179.8KB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 308.2KB 308.8KB +613.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 6f857dd into elastic:master Feb 16, 2021
@ThomThomson ThomThomson mentioned this pull request Feb 16, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 16, 2021
@ThomThomson
[Time to Visualize] Combine Discard & Cancel (elastic#91267)
8f3de93 
* recombined discard and cancel button functionality
# Conflicts:
#	test/functional/apps/dashboard/view_edit.ts
ThomThomson added a commit that referenced this pull request Feb 16, 2021
@ThomThomson
[Time to Visualize] Combine Discard & Cancel (#91267) (#91533)
04eca96 
* recombined discard and cancel button functionality
# Conflicts:
#	test/functional/apps/dashboard/view_edit.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Project:TimeToVisualize release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomThomson @elasticmachine @kibanamachine @clintandrewhall