Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.11] [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748) #93169

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

yctercero
Copy link
Contributor

Backports the following commits to 7.11:

…gnals (elastic#92748)

### Summary

Fixes a bug where max_signals was being reverted to it's default value when the rule was edited via the UI.
# Conflicts:
#	x-pack/plugins/security_solution/cypress/integration/detection_rules/custom_query_rule.spec.ts
@yctercero yctercero enabled auto-merge (squash) March 2, 2021 03:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +64.0B
triggersActionsUi 1.5MB 1.5MB -26.9KB
total -26.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 165.1KB 165.2KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit 453a1d9 into elastic:7.11 Mar 2, 2021
@yctercero yctercero deleted the backport/7.11/pr-92748 branch October 13, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants