[Search Embeddable] Add highlighting when searching #93178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
v7.12.0
release_note:skip
kertal
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Code LGTM 👍 Since the test coverage of the saved_search embeddable is low, could you add a functional for it to catch it in the future? Theoretically it should work like this test in the the Discover test suite:
kibana/test/functional/apps/discover/_field_data.ts
Lines 44 to 51 in 4614202
ThomThomson
approved these changes
Mar 2, 2021
wylieconlon
reviewed
Mar 2, 2021
| this.filtersSearchSource!.setField('highlightAll', true); | ||
| } else { | ||
| this.filtersSearchSource!.removeField('highlightAll'); | ||
| } |
There was a problem hiding this comment.
It looks like you've made the highlighting conditional, but the Discover app does it unconditionally. Why the difference?
There was a problem hiding this comment.
I don't think we need it once the filter/query is removed, feels cleaner this way
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Mar 3, 2021
* [Search Embeddable] Add highlighting when searching * Adding a functional test
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Mar 3, 2021
* [Search Embeddable] Add highlighting when searching * Adding a functional test
majagrubic
pushed a commit
that referenced
this pull request
Mar 3, 2021
majagrubic
pushed a commit
that referenced
this pull request
Mar 3, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2021
* master: (45 commits) Add outcome of node scripts/build_api_docs (elastic#93399) [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279) [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224) [uptime] Fix anomaly alert edit (elastic#93025) Consolidate @babel/* packages and use latest compatible version (elastic#93264) [Search Embeddable] Add highlighting when searching (elastic#93178) [APM] Add missing bottom border to header (elastic#93179) [CI] No longer collect APM span stack traces (elastic#93263) [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024) update generated public api docs API DOCS Step 3/3 (elastic#92929) chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262) rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620) [kbn/optimizer] allow customizing the limits path from the script (elastic#93153) [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830) [jenkins] convert baseline capture job to use tasks (elastic#93288) removing the linked issue in comments from PR (elastic#93303) chore(NA): do not include fs within a storybook build (elastic#93294) [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156) Add searchDuration to EQL and Threshold rules (elastic#93149) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #93093
Adds highlighting for filtering and search results in the search embeddable.
filtering_highlight.mp4
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers