Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel] More resilient Workspace Status #93244

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Mar 2, 2021

The workspace status check should never cause the build to fail as these are purely metrics to assist us with identifying issues with builds. This will prevent the check from failing if Git is not installed, or the .git directory is not available.

With Git:

$ node src/dev/bazel_workspace_status.js; echo $?
REPO_URL [email protected]:tylersmalley/kibana.git
COMMIT_SHA 5e440c62ea4dfc9e5d9f714cc79a9ad4b1da8b10
GIT_BRANCH no-fail-bazel
GIT_TREE_STATUS Clean
0

Without Git:

$ node src/dev/bazel_workspace_status.js; echo $?
0

@tylersmalley tylersmalley added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0 labels Mar 2, 2021
@tylersmalley tylersmalley marked this pull request as ready for review March 2, 2021 15:26
@tylersmalley tylersmalley requested a review from a team as a code owner March 2, 2021 15:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 5521fe4 into elastic:master Mar 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #93273
7.x / #93275

Successful backport PRs will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
* master: (199 commits)
  Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969)
  [Bazel] More resilient Workspace Status (elastic#93244)
  [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001)
  [Workplace Search] Role Mappings to Kibana (elastic#93123)
  [Fleet] Use type-only imports where possible (elastic#92979)
  [Lens] Set pie chart slices sorted clockwise (elastic#92617)
  Remove ms label from CPU load on status page (elastic#92836)
  [App Search] Migrate Create Meta Engine View (elastic#92127)
  [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917)
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  ...
kibanamachine added a commit that referenced this pull request Mar 2, 2021
Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Tyler Smalley <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
Signed-off-by: Tyler Smalley <[email protected]>

Co-authored-by: Tyler Smalley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants