[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note #93306

parkiino · 2021-03-02T20:15:12Z

Summary

Adds a restrictions tooltip for the "Register as Antivirus" section in the policy details page
Adjusts the spacing between the header words in the policy cards (this is to ensure longer policy types, such as Register as Antivirus, are on one line

TODO in future PR: extract out radio buttons component for easier reusability / reduce code redundancy

Screenshots

AV NOTE

HEADER SPACING BEFORE

HEADER SPACING AFTER

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-03-02T20:15:14Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

elasticmachine · 2021-03-02T20:15:14Z

Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint)

kevinlog · 2021-03-02T20:49:27Z

Feels like we should have a small amount of padding in between "Restrictions" and the tooltip.

@bfishel ?

Other than that LGTM!

paul-tavares · 2021-03-02T21:59:50Z

...olution/public/management/pages/policy/view/components/antivirus_registration_form/index.tsx

+      type={TRANSLATIONS.title}
+      supportedOss={[OperatingSystem.WINDOWS]}
+      osRestriction={
+        <>


I found that when this is displayed in Fleet, the tooltip wraps to its own line:

Suggestion: breach this out to a component (instead of inline here) and wrap the two element below in Flex components that don't grow or wrap.

parkiino · 2021-03-04T17:55:39Z

@elasticmachine merge upstream

…v-note

kibanamachine · 2021-03-04T20:06:24Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 36a5272
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup8

Test Failures

Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/delete·ts.spaces api with security delete rbac user with all globally from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: spaces api with security
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_legacy_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_dual_privileges_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_default_space_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_default_space_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_2_all_user]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.ds-ilm-history-5-2021.03.04-000001] creating index, cause [initialize_data_stream], templates [ilm-history], shards [1]/[0]
[00:00:00]             │ info [o.e.c.m.MetadataCreateDataStreamService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] adding data stream [ilm-history-5] with write index [.ds-ilm-history-5-2021.03.04-000001] and backing indices []
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_2_read_user]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] moving index [.ds-ilm-history-5-2021.03.04-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_2_all_user]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.ds-ilm-history-5-2021.03.04-000001][0]]])." previous.health="YELLOW" reason="shards started [[.ds-ilm-history-5-2021.03.04-000001][0]]"
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] moving index [.ds-ilm-history-5-2021.03.04-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_2_read_user]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] moving index [.ds-ilm-history-5-2021.03.04-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_default_space_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_default_space_saved_objects_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added role [kibana_rbac_space_1_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [not_a_kibana_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_default_space_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_default_space_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_default_space_saved_objects_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_kibana_rbac_space_1_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_apm_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_machine_learning_admin]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_machine_learning_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] added user [a_monitoring_user]
[00:03:47]           └-: delete
[00:03:47]             └-> "before all" hook in "delete"
[00:04:56]             └-: rbac user with all globally from the space_1 space
[00:04:56]               └-> "before all" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]               └-> should return 204 when referencing the space_1 space explicitly in the URL
[00:04:56]                 └-> "before each" hook: global before each for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                 └-> "before each" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:56]                   │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:56]                   │ info [saved_objects/spaces] Loading "data.json"
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_task_manager_8.0.0_001/X-JpzaigRr2GjmNswWvnIg] deleting index
[00:04:56]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_8.0.0_001/RKn9kF6cRXexYOYIKLjb0g] deleting index
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_8.0.0_001"
[00:04:56]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_8.0.0_001] creating index, cause [api], templates [], shards [1]/[0]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:04:56]                   │ info [saved_objects/spaces] Created index ".kibana_8.0.0_001"
[00:04:56]                   │ debg [saved_objects/spaces] ".kibana_8.0.0_001" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:56]                   │ info [saved_objects/spaces] Indexed 31 docs into ".kibana"
[00:04:56]                   │ debg Migrating saved objects
[00:04:56]                   │ proc [kibana]   log   [19:06:49.251] [warning][collector-set][plugins][usageCollection] ResponseError: index_not_found_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 404 },
[00:04:56]                   │ proc [kibana]     statusCode: 404,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '449'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [19:06:49.256] [warning][collector-set][plugins][usageCollection] Unable to fetch data from core collector
[00:04:56]                   │ proc [kibana]   log   [19:06:49.450] [warning][collector-set][plugins][usageCollection] ResponseError: search_phase_execution_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 400 },
[00:04:56]                   │ proc [kibana]     statusCode: 400,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '752'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [19:06:49.451] [warning][collector-set][plugins][usageCollection] Unable to fetch data from saved_objects_tagging collector
[00:04:56]                   │ proc [kibana]   log   [19:06:49.471] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET
[00:04:56]                   │ proc [kibana]   log   [19:06:49.474] [info][savedobjects-service] [.kibana] INIT -> OUTDATED_DOCUMENTS_SEARCH
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_task_manager_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_task_manager_8.0.0_001][0]]"
[00:04:57]                   │ proc [kibana]   log   [19:06:49.538] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:04:57]                   │ proc [kibana]   log   [19:06:49.540] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_8.0.0_001/rP_QtSqcQfCjqdt1LmMD_Q] update_mapping [_doc]
[00:04:57]                   │ proc [kibana]   log   [19:06:49.588] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:04:57]                   │ proc [kibana]   log   [19:06:49.597] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE
[00:04:57]                   │ proc [kibana]   log   [19:06:49.597] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 137ms
[00:04:57]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] 55670 finished with response BulkByScrollResponse[took=16.1ms,timed_out=false,sliceId=null,updated=31,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:57]                   │ proc [kibana]   log   [19:06:49.694] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE
[00:04:57]                   │ proc [kibana]   log   [19:06:49.695] [info][savedobjects-service] [.kibana] Migration completed after 236ms
[00:04:57]                   │ debg [saved_objects/spaces] Migrated Kibana index after loading Kibana data
[00:04:57]                   │ debg [saved_objects/spaces] Ensured that default space exists in .kibana
[00:04:57]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1614881502482806831] [.kibana_8.0.0_001/rP_QtSqcQfCjqdt1LmMD_Q] update_mapping [_doc]
[00:04:58]                 └- ✖ fail: spaces api with security delete rbac user with all globally from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL
[00:04:58]                 │       Error: expected [ { key: 'default',
[00:04:58]                 │     doc_count: 8,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { key: 'space_1',
[00:04:58]                 │     doc_count: 7,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ] to sort of equal [ { key: 'default',
[00:04:58]                 │     doc_count: 9,
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } },
[00:04:58]                 │   { doc_count: 7,
[00:04:58]                 │     key: 'space_1',
[00:04:58]                 │     countByType: 
[00:04:58]                 │      { doc_count_error_upper_bound: 0,
[00:04:58]                 │        sum_other_doc_count: 0,
[00:04:58]                 │        buckets: [Object] } } ]
[00:04:58]                 │       + expected - actual
[00:04:58]                 │ 
[00:04:58]                 │                  "key": "space"
[00:04:58]                 │                }
[00:04:58]                 │                {
[00:04:58]                 │                  "doc_count": 1
[00:04:58]                 │       +          "key": "config"
[00:04:58]                 │       +        }
[00:04:58]                 │       +        {
[00:04:58]                 │       +          "doc_count": 1
[00:04:58]                 │                  "key": "index-pattern"
[00:04:58]                 │                }
[00:04:58]                 │              ]
[00:04:58]                 │              "doc_count_error_upper_bound": 0
[00:04:58]                 │              "sum_other_doc_count": 0
[00:04:58]                 │            }
[00:04:58]                 │       -    "doc_count": 8
[00:04:58]                 │       +    "doc_count": 9
[00:04:58]                 │            "key": "default"
[00:04:58]                 │          }
[00:04:58]                 │          {
[00:04:58]                 │            "countByType": {
[00:04:58]                 │       
[00:04:58]                 │       at Assertion.assert (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:58]                 │       at Assertion.eql (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:58]                 │       at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
[00:04:58]                 │       at runMicrotasks (<anonymous>)
[00:04:58]                 │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:58]                 │ 
[00:04:58]                 │

Stack Trace

Error: expected [ { key: 'default',
    doc_count: 8,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { key: 'space_1',
    doc_count: 7,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ] to sort of equal [ { key: 'default',
    doc_count: 9,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { doc_count: 7,
    key: 'space_1',
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ]
    at Assertion.assert (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:244:8)
    at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  actual: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 8\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 9\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	+1.5KB

History

💚 Build #111139 succeeded 656d8a2
💚 Build #110983 succeeded 8ae45d0
💔 Build #110505 failed a945805

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ctions tooltip note (#93306) (#93689)

…into actions/terminology-api * 'actions/terminology-api' of github.com:gmmorris/kibana: Make Dashboard Unsaved Changes Space Specific (elastic#92680) Hide Value and Funtional boost for geolocation (elastic#93683) [Fleet] Set all keyword and text fields for `index.query.default_field` index template setting (elastic#91791) can not query the world (elastic#93556) [Security Solutions] Sets our default date time to be "today" instead of "Last 24 hours" to enable cachability and fixes one date math bug in the URL (elastic#93548) [Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note (elastic#93306) fix agg config sub agg dsl generation (elastic#93276)

…ctions tooltip note (elastic#93306)

…ctions tooltip note (#93306) (#93849)

parkiino added 5 commits February 23, 2021 10:57

add osRestriction prop

aaf521d

tooltip text updated

4afdc38

Merge remote-tracking branch 'upstream/master' into task/av-note

32ee767

Merge remote-tracking branch 'upstream/master' into task/av-note

b3692f5

prettify

a945805

parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 labels Mar 2, 2021

parkiino requested a review from a team as a code owner March 2, 2021 20:15

parkiino mentioned this pull request Mar 2, 2021

Add note to "Register as AV" Section in Endpoint Integration Policy #90261

Closed

2 tasks

paul-tavares reviewed Mar 2, 2021

View reviewed changes

parkiino added 2 commits March 3, 2021 23:02

fix jest test, remove osrestriction to component

b6b39cc

more resuable

8ae45d0

Merge branch 'master' into task/av-note

656d8a2

kevinlog approved these changes Mar 4, 2021

View reviewed changes

parkiino added 2 commits March 4, 2021 13:09

subdued icon

754fe30

Merge branch 'task/av-note' of github.com:parkiino/kibana into task/a…

36a5272

…v-note

parkiino merged commit 28750e9 into elastic:master Mar 4, 2021

parkiino deleted the task/av-note branch March 4, 2021 21:05

parkiino mentioned this pull request Mar 4, 2021

[7.x] [Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note (#93306) #93689

Merged

parkiino added a commit that referenced this pull request Mar 4, 2021

[Security Solution][Endpoint][Admin][Policy] Register as AV os restri…

eeeabc7

…ctions tooltip note (#93306) (#93689)

parkiino mentioned this pull request Mar 5, 2021

[7.12] [Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note (#93306) #93849

Merged

parkiino added a commit to parkiino/kibana that referenced this pull request Mar 5, 2021

[Security Solution][Endpoint][Admin][Policy] Register as AV os restri…

a949074

…ctions tooltip note (elastic#93306)

parkiino added a commit that referenced this pull request Mar 6, 2021

[Security Solution][Endpoint][Admin][Policy] Register as AV os restri…

e76396a

…ctions tooltip note (#93306) (#93849)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note #93306

[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note #93306

parkiino commented Mar 2, 2021 •

edited

Loading

elasticmachine commented Mar 2, 2021

elasticmachine commented Mar 2, 2021

kevinlog commented Mar 2, 2021

paul-tavares Mar 2, 2021

parkiino commented Mar 4, 2021

kibanamachine commented Mar 4, 2021

Standard Out

Stack Trace

[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note #93306

[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note #93306

Conversation

parkiino commented Mar 2, 2021 • edited Loading

Summary

Screenshots

Checklist

elasticmachine commented Mar 2, 2021

elasticmachine commented Mar 2, 2021

kevinlog commented Mar 2, 2021

paul-tavares Mar 2, 2021

Choose a reason for hiding this comment

parkiino commented Mar 4, 2021

kibanamachine commented Mar 4, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

parkiino commented Mar 2, 2021 •

edited

Loading