Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Remove use of deprecated $opacity #93456

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[Maps] Remove use of deprecated $opacity #93456

merged 1 commit into from
Mar 3, 2021

Conversation

thomasneirynck
Copy link
Contributor

$opacity is deprecated in the upcoming Amsterdam EUI theme.

This is now just producing spam at build-time.

13:44:27     │ warn worker stderr WARNING: The $opacity variable of euiBottomShadowMedium() will be depricated in a future version of EUI.
13:44:27     │ warn worker stderr          on line 35 of node_modules/@elastic/eui/src/themes/eui-amsterdam/global_styling/mixins/_shadow.scss, in mixin `euiBottomShadowMedium`
13:44:27     │ warn worker stderr          from line 12 of src/plugins/maps_legacy/public/map/_leaflet_overrides.scss
13:44:27     │ warn worker stderr          from line 3 of stdin
13:44:27     │ warn worker stderr 
13:44:27     │ warn worker stderr WARNING: The $opacity variable of euiBottomShadowMedium() will be depricated in a future version of EUI.
13:44:27     │ warn worker stderr          on line 35 of node_modules/@elastic/eui/src/themes/eui-amsterdam/global_styling/mixins/_shadow.scss, in mixin `euiBottomShadowMedium`
13:44:27     │ warn worker stderr          from line 3 of src/plugins/maps_legacy/public/map/_legend.scss
13:44:27     │ warn worker stderr          from line 4 of stdin
13:44:27     │ warn worker stderr

@thomasneirynck thomasneirynck requested a review from a team as a code owner March 3, 2021 16:44
@thomasneirynck thomasneirynck added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck changed the title [Maps] Remove use of deprecated &opacity [Maps] Remove use of deprecated $opacity Mar 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

miukimiu
miukimiu approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

By default, the mixin euiBottomShadowMedium() returns an opacity of .2 which doesn't make much difference.

@thomasneirynck thomasneirynck merged commit a620179 into elastic:master Mar 3, 2021
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Mar 3, 2021
@thomasneirynck
remove opacity from maps legacy style (elastic#93456)
9afaffc
@thomasneirynck thomasneirynck mentioned this pull request Mar 3, 2021
Merged
thomasneirynck added a commit that referenced this pull request Mar 3, 2021
@thomasneirynck
remove opacity from maps legacy style (#93456) (#93513)
afac4c8
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
6a3b8b3 
* master: (48 commits)
  Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448)
  [Fleet] Correctly track install status of an integration (elastic#93464)
  Reviews data frame analytics UI text (elastic#93033)
  Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280)
  [Security Solution][Detections] ML Popover overflow fix (elastic#93525)
  chore(NA): do not use execa on bazel workspace status update script (elastic#93532)
  Bump dependencies (elastic#93511)
  [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529)
  [Security Solution] fix data provider cypress test (elastic#93465)
  Fix service map for All environment single service (elastic#93517)
  [Fleet] Fix package version comparaison in the UI (elastic#93498)
  [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720)
  [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473)
  [core-new-docs] Adds a dev-doc for core documentation (elastic#92976)
  remove opacity from maps legacy style (elastic#93456)
  [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176)
  Revert "Make tests deterministic by providing unique timestamps (elastic#93350)"
  [Discover] Fix link from dashboard saved search to Discover (elastic#92937)
  update public api docs
  App Search - Polishing Analytics Views (elastic#92939)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @kibanamachine @miukimiu