Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Make session_state optional in source request #94219

Merged
merged 1 commit into from
Mar 10, 2021
Merged

[Workplace Search] Make session_state optional in source request #94219

merged 1 commit into from
Mar 10, 2021

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Mar 9, 2021 •
edited
Loading

Some OAuth plugins don’t send this key so we make it optional to prevent server errors.

@scottybollinger
[Workplace Search] Make session_state optional
55b9bf4 
Some OAuth plugins don’t send this key so we make it optional to prevent server errors.
@scottybollinger scottybollinger changed the title [Workplace Search] Make session_state optional [Workplace Search] Make session_state optional in source request Mar 9, 2021
@scottybollinger scottybollinger added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 9, 2021
@scottybollinger scottybollinger marked this pull request as ready for review March 9, 2021 22:12
@scottybollinger scottybollinger requested review from a team and jgr March 9, 2021 22:12
@scottybollinger scottybollinger enabled auto-merge (squash) March 9, 2021 22:13
jgr
jgr approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jgr jgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 89a4355 into elastic:master Mar 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 10, 2021
@scottybollinger @kibanamachine
[Workplace Search] Make session_state optional (elastic#94219)
2422993 
Some OAuth plugins don’t send this key so we make it optional to prevent server errors.
@kibanamachine kibanamachine mentioned this pull request Mar 10, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #94246

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 10, 2021
@kibanamachine @scottybollinger
[Workplace Search] Make session_state optional (#94219) (#94246)
a0b8ea6 
Some OAuth plugins don’t send this key so we make it optional to prevent server errors.

Co-authored-by: Scotty Bollinger <[email protected]>
@scottybollinger scottybollinger deleted the scottybollinger/maybe-sources branch March 11, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgr jgr jgr approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @jgr