Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize slider value selection #94313

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[ML] Functional tests - stabilize slider value selection #94313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions x-pack/test/functional/services/ml/common_ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
async setSliderValue(testDataSubj: string, value: number) {
const slider = await testSubjects.find(testDataSubj);

let currentValue = await slider.getAttribute('value');
let currentDiff = +currentValue - +value;

await retry.tryForTime(60 * 1000, async () => {
const currentValue = await slider.getAttribute('value');
const currentDiff = +currentValue - +value;

if (currentDiff === 0) {
return true;
} else {
Expand All @@ -189,20 +189,13 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
}
await retry.tryForTime(1000, async () => {
const newValue = await slider.getAttribute('value');
if (newValue !== currentValue) {
currentValue = newValue;
currentDiff = +currentValue - +value;
return true;
} else {
if (newValue === currentValue) {
throw new Error(`slider value should have changed, but is still ${currentValue}`);
}
});

throw new Error(`slider value should be '${value}' (got '${currentValue}')`);
await this.assertSliderValue(testDataSubj, value);
}
});

await this.assertSliderValue(testDataSubj, value);
},

async assertSliderValue(testDataSubj: string, expectedValue: number) {
Expand Down