[Security Solution] Remove graphQL host #94592

angorayc · 2021-03-15T16:09:51Z

Summary

This PR is to remove graphQL endpoint for host entirely. Before this PR we've replace every endpoint of host with search strategy except from host details.

Steps to verify:

Go to host page.
Enable the dev tool of Chrome and switch to network tab, filter graphql, make sure nothing appears.
Click any host name on the page and land on host details page. Wait for the page to load. Observe the network panel in dev tool, make sure no graphql request appears.

elasticmachine · 2021-03-17T13:28:39Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-03-17T13:28:40Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

angorayc · 2021-03-17T17:58:33Z

@elasticmachine merge upstream

angorayc · 2021-03-18T06:42:20Z

@elasticmachine merge upstream

angorayc · 2021-03-22T07:06:47Z

@elasticmachine merge upstream

angorayc · 2021-03-24T07:09:00Z

@elasticmachine merge upstream

angorayc · 2021-03-26T08:40:47Z

@elasticmachine merge upstream

…graphql-host

XavierM · 2021-03-30T19:54:23Z

...ck/plugins/security_solution/common/search_strategy/security_solution/hosts/details/index.ts

+      field: string;
+    };
+    aggs?: {
+      [aggSortField: string]: {


are you sure that 's aggSortField here?

yeah, I took it from https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/types.ts#L186

maybe we could switch to elasticsearch types now? #83808

ok, replaced line 27 - 62 with estypes.AggregationContainer

XavierM · 2021-03-30T19:54:47Z

...ns/security_solution/common/search_strategy/security_solution/hosts/first_last_seen/index.ts

 import { RequestOptionsPaginated } from '../..';
 import { HostsFields } from '../common';

 export interface HostFirstLastSeenRequestOptions
  extends Partial<RequestOptionsPaginated<HostsFields>> {
  hostName: string;
-  order: 'asc' | 'desc';
+  order: Direction.asc | Direction.desc;


x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx

x-pack/plugins/security_solution/public/hosts/components/hosts_table/index.tsx

…_table/columns.tsx Co-authored-by: Xavier Mouligneau <[email protected]>

x-pack/plugins/security_solution/public/hosts/components/hosts_table/index.tsx

…graphql-host

angorayc · 2021-03-31T14:14:17Z

@elasticmachine merge upstream

angorayc · 2021-03-31T15:35:43Z

@elasticmachine merge upstream

…graphql-host

XavierM

I think we should not just call the factoryQueryType details but hostDetails

angorayc · 2021-04-06T09:16:50Z

@elasticmachine merge upstream

kibanamachine · 2021-04-06T11:22:55Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2209	2208	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.3MB	7.3MB	-7.0KB

History

💛 Build #117455 was flaky 2a99ff8
💔 Build #117464 failed 2591767
💚 Build #117191 succeeded cb005b4
💚 Build #116561 succeeded 6b7d32a
💔 Build #116539 failed 355e94a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* rm host from graphql * clean up * rm SortRequestDirection * fix types * rm comment * fix types * fix unit test * fix unit test * Update x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx Co-authored-by: Xavier Mouligneau <[email protected]> * revert assertUnreachable * use estypes * rename details to HostDetails Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>

* rm host from graphql * clean up * rm SortRequestDirection * fix types * rm comment * fix types * fix unit test * fix unit test * Update x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx Co-authored-by: Xavier Mouligneau <[email protected]> * revert assertUnreachable * use estypes * rename details to HostDetails Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>

angorayc added 9 commits March 15, 2021 23:00

rm host from graphql

166234c

clean up

f3845e9

rm SortRequestDirection

aa8ce5d

fix types

dd6f115

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

8015fb3

rm comment

d505f73

fix types

32b8330

fix unit test

663851d

fix unit test

61b1063

angorayc added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 Team:Threat Hunting Security Solution Threat Hunting Team release_note:skip Skip the PR/issue when compiling release notes labels Mar 16, 2021

angorayc marked this pull request as ready for review March 17, 2021 13:28

angorayc requested a review from a team as a code owner March 17, 2021 13:28

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

258f067

Merge branch 'master' into rm-graphql-host

3a722c5

Merge branch 'master' into rm-graphql-host

4c01239

Merge branch 'master' into rm-graphql-host

ecbb417

angorayc mentioned this pull request Mar 23, 2021

[Security Solution] Remove graphQL in Security Solution #95156

Closed

4 tasks

Merge branch 'master' into rm-graphql-host

b75aeb7

kibanamachine and others added 2 commits March 26, 2021 04:40

Merge branch 'master' into rm-graphql-host

72810a1

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

90b52b9

Merge branch 'rm-graphql-host' of github.com:angorayc/kibana into rm-…

ac1b3ed

…graphql-host

michaelolo24 requested a review from a team March 29, 2021 18:36

XavierM reviewed Mar 30, 2021

View reviewed changes

x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx Outdated Show resolved Hide resolved

XavierM reviewed Mar 30, 2021

View reviewed changes

x-pack/plugins/security_solution/public/hosts/components/hosts_table/index.tsx Show resolved Hide resolved

Update x-pack/plugins/security_solution/public/hosts/components/hosts…

f40f301

…_table/columns.tsx Co-authored-by: Xavier Mouligneau <[email protected]>

patrykkopycinski reviewed Mar 31, 2021

View reviewed changes

x-pack/plugins/security_solution/public/hosts/components/hosts_table/index.tsx Show resolved Hide resolved

angorayc added 3 commits March 31, 2021 16:50

revert assertUnreachable

f4fecc1

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

e3af283

Merge branch 'rm-graphql-host' of github.com:angorayc/kibana into rm-…

fef0a17

…graphql-host

Merge branch 'master' into rm-graphql-host

355e94a

kibanamachine and others added 4 commits March 31, 2021 11:48

Merge branch 'master' into rm-graphql-host

6b7d32a

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

d788620

use estypes

2916527

Merge branch 'rm-graphql-host' of github.com:angorayc/kibana into rm-…

cb005b4

…graphql-host

XavierM reviewed Apr 5, 2021

View reviewed changes

angorayc added 2 commits April 6, 2021 08:58

rename details to HostDetails

2a99ff8

Merge branch 'master' of github.com:elastic/kibana into rm-graphql-host

2591767

Merge branch 'master' into rm-graphql-host

a002674

XavierM approved these changes Apr 6, 2021

View reviewed changes

angorayc merged commit 8b5e2fb into elastic:master Apr 6, 2021

angorayc mentioned this pull request Apr 6, 2021

[7.x] [Security Solution] Remove graphQL host (#94592) #96303

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Remove graphQL host #94592

[Security Solution] Remove graphQL host #94592

angorayc commented Mar 15, 2021 •

edited

Loading

elasticmachine commented Mar 17, 2021

elasticmachine commented Mar 17, 2021

angorayc commented Mar 17, 2021

angorayc commented Mar 18, 2021

angorayc commented Mar 22, 2021

angorayc commented Mar 24, 2021

angorayc commented Mar 26, 2021

XavierM Mar 30, 2021

angorayc Mar 31, 2021 •

edited

Loading

patrykkopycinski Mar 31, 2021 •

edited

Loading

angorayc Apr 5, 2021

XavierM Mar 30, 2021

angorayc commented Mar 31, 2021

angorayc commented Mar 31, 2021

XavierM left a comment

angorayc commented Apr 6, 2021

kibanamachine commented Apr 6, 2021

[Security Solution] Remove graphQL host #94592

[Security Solution] Remove graphQL host #94592

Conversation

angorayc commented Mar 15, 2021 • edited Loading

Summary

elasticmachine commented Mar 17, 2021

elasticmachine commented Mar 17, 2021

angorayc commented Mar 17, 2021

angorayc commented Mar 18, 2021

angorayc commented Mar 22, 2021

angorayc commented Mar 24, 2021

angorayc commented Mar 26, 2021

XavierM Mar 30, 2021

Choose a reason for hiding this comment

angorayc Mar 31, 2021 • edited Loading

Choose a reason for hiding this comment

patrykkopycinski Mar 31, 2021 • edited Loading

Choose a reason for hiding this comment

angorayc Apr 5, 2021

Choose a reason for hiding this comment

XavierM Mar 30, 2021

Choose a reason for hiding this comment

angorayc commented Mar 31, 2021

angorayc commented Mar 31, 2021

XavierM left a comment

Choose a reason for hiding this comment

angorayc commented Apr 6, 2021

kibanamachine commented Apr 6, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

angorayc commented Mar 15, 2021 •

edited

Loading

angorayc Mar 31, 2021 •

edited

Loading

patrykkopycinski Mar 31, 2021 •

edited

Loading