-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add ML plugin contract mocks #96265
Conversation
@elasticmachine merge upstream |
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, happy to get this code into the right plugin 😉 . The existing mocks certainly serve our immediate needs, but we'll reach out (likely with a PR) if/when that changes!
@@ -5,25 +5,9 @@ | |||
* 2.0. | |||
*/ | |||
|
|||
import { MlPluginSetup } from '../../../../ml/server'; | |||
import { elasticsearchServiceMock } from '../../../../../../src/core/server/mocks'; | |||
import { mlPluginServerMock } from '../../../../ml/server/mocks'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think kibana preference is to import these mocks directly in the consuming tests, but this makes sense to keep changes here to a minimum 👍 We (SecSol) can absolutely do this in a followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @qn895 |
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Quynh Nguyen <[email protected]>
Summary
This PR addresses #66603 by adding jest mocks for ML plugins (both public and server API). It also replaces
mlServicesMock
for security solutions from #65583 with the new mock.Checklist